Prev: [015/139] x86,kgdb: Always initialize the hw breakpoint attribute
Next: [014/139] [SCSI] libiscsi: Fix recovery slowdown regression
From: Greg KH on 22 Apr 2010 16:40
2.6.33-stable review patch. If anyone has any objections, please let us know.

------------------

From: Matt Fleming <matt(a)console-pimps.org>

commit 4bea3418c737891894b9d3d3e9f8bbd67d66fa38 upstream.

For the boot, enable_mmu() is called from setup_arch() but we don't call
setup_arch() for any of the other cpus. So turn on the non-boot cpu's
mmu inside of start_secondary().

I noticed this bug on an SMP board when trying to map I/O memory
(smsc911x registers) into the kernel address space. Since the Address
Translation bit in MMUCR wasn't set, accessing the virtual address where
the smsc911x registers were supposedly mapped actually performed a
physical address access.

Signed-off-by: Matt Fleming <matt(a)console-pimps.org>
Signed-off-by: Paul Mundt <lethal(a)linux-sh.org>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>

---
arch/sh/kernel/smp.c | 1 +
1 file changed, 1 insertion(+)

--- a/arch/sh/kernel/smp.c
+++ b/arch/sh/kernel/smp.c
@@ -69,6 +69,7 @@ asmlinkage void __cpuinit start_secondar
unsigned int cpu;
struct mm_struct *mm = &init_mm;

+ enable_mmu();
atomic_inc(&mm->mm_count);
atomic_inc(&mm->mm_users);
current->active_mm = mm;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [015/139] x86,kgdb: Always initialize the hw breakpoint attribute
Next: [014/139] [SCSI] libiscsi: Fix recovery slowdown regression