Prev: [112/117] SCSI: fix locking around blk_abort_request()
Next: [095/117] WAN: flush tx_queue in hdlc_ppp to prevent panic on rmmod hw_driver.
From: Greg KH on 10 May 2010 19:30
2.6.33-stable review patch. If anyone has any objections, please let us know.
From: Michael S. Tsirkin <mst(a)redhat.com>
[ Upstream commit 0110d6f22f392f976e84ab49da1b42f85b64a3c5 ]
The following situation was observed in the field:
tap1 sends packets, tap2 does not consume them, as a result
tap1 can not be closed. This happens because
tun/tap devices can hang on to skbs undefinitely.
As noted by Herbert, possible solutions include a timeout followed by a
copy/change of ownership of the skb, or always copying/changing
ownership if we're going into a hostile device.
This patch implements the second approach.
Note: one issue still remaining is that since skbs
keep reference to tun socket and tun socket has a
reference to tun device, we won't flush backlog,
instead simply waiting for all skbs to get transmitted.
At least this is not user-triggerable, and
this was not reported in practice, my assumption is
other devices besides tap complete an skb
within finite time after it has been queued.
A possible solution for the second issue
would not to have socket reference the device,
instead, implement dev->destructor for tun, and
wait for all skbs to complete there, but this
needs some thought, probably too risky for 2.6.34.
Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com>
Tested-by: Yan Vugenfirer <yvugenfi(a)redhat.com>
Acked-by: Herbert Xu <herbert(a)gondor.apana.org.au>
Signed-off-by: David S. Miller <davem(a)davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>
drivers/net/tun.c | 4 ++++
1 file changed, 4 insertions(+)
@@ -380,6 +380,10 @@ static netdev_tx_t tun_net_xmit(struct s
+ /* Orphan the skb - required as we might hang on to it
+ * for indefinite time. */
/* Enqueue packet */
dev->trans_start = jiffies;
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/