From: Luming Yu on
Hi there,

I happened to notice that the commit 365cfa1ed5 caused the following
boot error with 2.6.25-rc1
on a system with ICH10 SATA AHCI controller. It's weird if there is
really no function changes in the patch.

Any ideas?


dracut: Starting plymouth daemon
pata_jmicron 0000:0f:00.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
scsi0 : pata_jmicron
Initializing USB Mass Storage driver...
scsi1 : usb-storage 1-5:1.0
scsi2 : pata_jmicron
ata1: PATA max UDMA/100 cmd 0xd040 ctl 0xd030 bmdma 0xd000 irq 16
ata2: PATA max UDMA/100 cmd 0xd020 ctl 0xd010 bmdma 0xd008 irq 16
usbcore: registered new interface driver usb-storage
USB Mass Storage support registered.
scsi 1:0:0:0: CD-ROM PepperC Virtual Disc 1 0.01 PQ: 0 ANSI: 3
sr0: scsi-1 drive



commit 365cfa1ed5a36f9bcb9f64c9f0f52155af2e9fef
Author: Anton Vorontsov <avorontsov(a)ru.mvista.com>
Date: Sun Mar 28 00:22:14 2010 -0400

ahci: Move generic code into libahci

This patch should contain no functional changes, just moves code
around.

Signed-off-by: Anton Vorontsov <avorontsov(a)ru.mvista.com>
Signed-off-by: Jeff Garzik <jgarzik(a)redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jeff Garzik on
On 06/03/2010 03:02 AM, Luming Yu wrote:
> Hi there,
>
> I happened to notice that the commit 365cfa1ed5 caused the following
> boot error with 2.6.25-rc1
> on a system with ICH10 SATA AHCI controller. It's weird if there is
> really no function changes in the patch.
>
> Any ideas?
>
>
> dracut: Starting plymouth daemon
> pata_jmicron 0000:0f:00.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
> scsi0 : pata_jmicron
> Initializing USB Mass Storage driver...
> scsi1 : usb-storage 1-5:1.0
> scsi2 : pata_jmicron
> ata1: PATA max UDMA/100 cmd 0xd040 ctl 0xd030 bmdma 0xd000 irq 16
> ata2: PATA max UDMA/100 cmd 0xd020 ctl 0xd010 bmdma 0xd008 irq 16
> usbcore: registered new interface driver usb-storage
> USB Mass Storage support registered.
> scsi 1:0:0:0: CD-ROM PepperC Virtual Disc 1 0.01 PQ: 0 ANSI: 3
> sr0: scsi-1 drive

Your output here does not indicate a boot error, so to what do you refer?

Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Luming Yu on
On Thu, Jun 3, 2010 at 3:13 PM, Jeff Garzik <jeff(a)garzik.org> wrote:
> On 06/03/2010 03:02 AM, Luming Yu wrote:
>>
>> Hi there,
>>
>> I happened to notice that the commit 365cfa1ed5 caused the following
>> boot error with 2.6.25-rc1
>> on a system with ICH10 SATA AHCI controller. It's weird if there is
>> really no function changes in the patch.
>>
>> Any ideas?
>>
>>
>> dracut: Starting plymouth daemon
>> pata_jmicron 0000:0f:00.0: PCI INT A ->  GSI 16 (level, low) ->  IRQ 16
>> scsi0 : pata_jmicron
>> Initializing USB Mass Storage driver...
>> scsi1 : usb-storage 1-5:1.0
>> scsi2 : pata_jmicron
>> ata1: PATA max UDMA/100 cmd 0xd040 ctl 0xd030 bmdma 0xd000 irq 16
>> ata2: PATA max UDMA/100 cmd 0xd020 ctl 0xd010 bmdma 0xd008 irq 16
>> usbcore: registered new interface driver usb-storage
>> USB Mass Storage support registered.
>> scsi 1:0:0:0: CD-ROM            PepperC  Virtual Disc 1   0.01 PQ: 0 ANSI:
>> 3
>> sr0: scsi-1 drive
>
> Your output here does not indicate a boot error, so to what do you refer?
sr0: scsi-1 drive
Uniform CD-ROM driver Revision: 3.20

Boot has failed, sleeping forever.




>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Anton Vorontsov on
On Thu, Jun 03, 2010 at 03:02:25PM +0800, Luming Yu wrote:
> Hi there,
>
> I happened to notice that the commit 365cfa1ed5 caused the following
> boot error with 2.6.25-rc1
> on a system with ICH10 SATA AHCI controller. It's weird if there is
> really no function changes in the patch.
>
> Any ideas?
>
>
> dracut: Starting plymouth daemon
> pata_jmicron 0000:0f:00.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
> scsi0 : pata_jmicron
> Initializing USB Mass Storage driver...
> scsi1 : usb-storage 1-5:1.0
> scsi2 : pata_jmicron
> ata1: PATA max UDMA/100 cmd 0xd040 ctl 0xd030 bmdma 0xd000 irq 16
> ata2: PATA max UDMA/100 cmd 0xd020 ctl 0xd010 bmdma 0xd008 irq 16
> usbcore: registered new interface driver usb-storage
> USB Mass Storage support registered.
> scsi 1:0:0:0: CD-ROM PepperC Virtual Disc 1 0.01 PQ: 0 ANSI: 3
> sr0: scsi-1 drive

Can you provide full boot log (dmesg) please?

I wonder if you're using ahci.ignore_sss and/or ahci.skip_host_reset
kernel command line options or module params. You should probably use
libahci.* for these now.

--
Anton Vorontsov
email: cbouatmailru(a)gmail.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Anton Vorontsov on
On Thu, Jun 03, 2010 at 04:11:57PM +0800, Luming Yu wrote:
> On Thu, Jun 3, 2010 at 3:54 PM, Anton Vorontsov <cbouatmailru(a)gmail.com> wrote:
[...]
> >> I happened to notice that the commit 365cfa1ed5 caused the following
> >> boot error with 2.6.25-rc1
[...]
> > Can you provide full boot log (dmesg) please?
[...]

I don't see any AHCI devices probed.

[...]
> ------------[ cut here ]------------
> WARNING: at fs/sysfs/dir.c:451 sysfs_add_one+0xc9/0x130()
> Hardware name: X8DTN
> sysfs: cannot create duplicate filename
> '/devices/pci0000:00/0000:00:1c.4/0000:0f:00.0/slot'

This looks suspicious.

> usb 1-5: New USB device found, idVendor=14dd, idProduct=0002

(...this is async USB stuff, doesn't matter...)

> Modules linked in:
> Pid: 1, comm: swapper Not tainted 2.6.35-rc1 #1
> Call Trace:
> [<ffffffff8105ed8f>] warn_slowpath_common+0x7f/0xc0
> [<ffffffff8105ee86>] warn_slowpath_fmt+0x46/0x50
> [<ffffffff811ad969>] sysfs_add_one+0xc9/0x130
> [<ffffffff811ae0f8>] sysfs_do_create_link+0xd8/0x1a0
> [<ffffffff811ae1f3>] sysfs_create_link+0x13/0x20
> [<ffffffff81236466>] pci_create_sysfs_dev_files+0x3d6/0x5f0

Anyway, I just tried to move code around from libahci.c
back to ahci.c by hand, to verify that there are actually
no code changes, and there isn't.

So, I wonder, have you actually bisected the thing correctly?
Does "git reset --hard 365cfa1ed5^" actually help and does
"git reset --hard 365cfa1ed5" actually break things?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/