Prev: [PATCH mmotm] vmscan: raise the bar to PAGEOUT_IO_SYNC stalls
Next: [PATCH] arch/sparc/mm: Use GFP_KERNEL
From: Thomas Meyer on 1 Aug 2010 05:10
This commit makes suspend to ram unreliable for me:

commit d1b851fc0d105caa6b6e3e7c92d2987dfb52cbe0
Author: Zou Nan hai <nanhai.zou(a)intel.com>
Date: Fri May 21 09:08:57 2010 +0800

drm/i915: implement BSD ring buffer V2

The BSD (bit stream decoder) ring is used for accessing the BSD engine
which decodes video bitstream for H.264 and VC1 on G45+. It is
asynchronous with the render ring and has access to separate parts of
the GPU from it, though the render cache is coherent between the two.

Signed-off-by: Zou Nan hai <nanhai.zou(a)intel.com>
Signed-off-by: Xiang Hai hao <haihao.xiang(a)intel.com>
Signed-off-by: Eric Anholt <eric(a)anholt.net>

git revert didn't work on 2.6.35-rc6 so I just changed the HAS_BSD thing to:

#define HAS_BSD(dev) (0)

with this change applied suspend to ram is back to the reliability of 2.6.34.y

with kind regards
thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Stefan Richter on 1 Aug 2010 07:50
Thomas Meyer wrote:
> This commit makes suspend to ram unreliable for me:
>
> commit d1b851fc0d105caa6b6e3e7c92d2987dfb52cbe0
> Author: Zou Nan hai <nanhai.zou(a)intel.com>
> Date: Fri May 21 09:08:57 2010 +0800
>
> drm/i915: implement BSD ring buffer V2
>
> The BSD (bit stream decoder) ring is used for accessing the BSD engine
> which decodes video bitstream for H.264 and VC1 on G45+. It is
> asynchronous with the render ring and has access to separate parts of
> the GPU from it, though the render cache is coherent between the two.
>
> Signed-off-by: Zou Nan hai <nanhai.zou(a)intel.com>
> Signed-off-by: Xiang Hai hao <haihao.xiang(a)intel.com>
> Signed-off-by: Eric Anholt <eric(a)anholt.net>
>
> git revert didn't work on 2.6.35-rc6 so I just changed the HAS_BSD thing to:
>
> #define HAS_BSD(dev) (0)
>
> with this change applied suspend to ram is back to the reliability of 2.6.34.y
>
> with kind regards
> thomas

Added CCs.

Thomas, on what hardware did you observe the regression? Is it suspend
or resume that is unreliable? What are the particular symptoms --- does
not suspend, crashes during suspend, crashes during resume...?
--
Stefan Richter
-=====-==-=- =--- ----=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Thomas Meyer on 1 Aug 2010 09:00
Am 01.08.2010 um 13:42 schrieb Stefan Richter <stefanr(a)s5r6.in-berlin.de>:

> Thomas Meyer wrote:
>> This commit makes suspend to ram unreliable for me:
>>
>> commit d1b851fc0d105caa6b6e3e7c92d2987dfb52cbe0
>> Author: Zou Nan hai <nanhai.zou(a)intel.com>
>> Date: Fri May 21 09:08:57 2010 +0800
>>
>> drm/i915: implement BSD ring buffer V2
>>
>> The BSD (bit stream decoder) ring is used for accessing the BSD engine
>> which decodes video bitstream for H.264 and VC1 on G45+. It is
>> asynchronous with the render ring and has access to separate parts of
>> the GPU from it, though the render cache is coherent between the two.
>>
>> Signed-off-by: Zou Nan hai <nanhai.zou(a)intel.com>
>> Signed-off-by: Xiang Hai hao <haihao.xiang(a)intel.com>
>> Signed-off-by: Eric Anholt <eric(a)anholt.net>
>>
>> git revert didn't work on 2.6.35-rc6 so I just changed the HAS_BSD thing to:
>>
>> #define HAS_BSD(dev) (0)
>>
>> with this change applied suspend to ram is back to the reliability of 2.6.34.y
>>
>> with kind regards
>> thomas
>
> Added CCs.
>
> Thomas, on what hardware did you observe the regression?

Is a Intel mobile express gm45 chipset.

> Is it suspend
> or resume that is unreliable?

suspend never finishes/hangs.

> What are the particular symptoms --- does
> not suspend, crashes during suspend, crashes during resume...?

Does not suspend, backlight is on.

> --
> Stefan Richter
> -=====-==-=- =--- ----=
> http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Paul Rolland on 1 Aug 2010 09:30
Hello Thomas,

On Sun, 1 Aug 2010 12:51:36 +0200
Thomas Meyer <thomas(a)m3y3r.de> wrote:

> Am 01.08.2010 um 13:42 schrieb Stefan Richter <stefanr(a)s5r6.in-berlin.de>:
>
> > Thomas, on what hardware did you observe the regression?
>
> Is a Intel mobile express gm45 chipset.

My machine has :
00:02.0 0300: 8086:2a42 (rev 07)
00:02.1 0380: 8086:2a43 (rev 07)

00:02.0 VGA compatible controller: Intel Corporation Mobile 4 Series Chipset Integrated Graphics Controller (rev 07)
00:02.1 Display controller: Intel Corporation Mobile 4 Series Chipset Integrated Graphics Controller (rev 07)

(Dell Vostro 1520, BIOS Revision A04)

> > Is it suspend
> > or resume that is unreliable?
> suspend never finishes/hangs.
and is randomly suffering from exactly the same problems...

So, I've applied your hint (in i915_drv.h), rebuilt a kernel, booted, and
I've now successfully managed to go thru several suspend/resume cycles
without having the machine hanging while suspend !

Will check in the long term, but so far, it's a win !

Thx,
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Roberto Oppedisano on 1 Aug 2010 11:20
On 01/08/2010 15:14, Paul Rolland wrote:
> My machine has :
> 00:02.0 0300: 8086:2a42 (rev 07)
> 00:02.1 0380: 8086:2a43 (rev 07)
>
> 00:02.0 VGA compatible controller: Intel Corporation Mobile 4 Series Chipset Integrated Graphics Controller (rev 07)
> 00:02.1 Display controller: Intel Corporation Mobile 4 Series Chipset Integrated Graphics Controller (rev 07)
>
> (Dell Vostro 1520, BIOS Revision A04)
>
>>> Is it suspend
>>> or resume that is unreliable?
>> suspend never finishes/hangs.
> and is randomly suffering from exactly the same problems...
>
> So, I've applied your hint (in i915_drv.h), rebuilt a kernel, booted, and
> I've now successfully managed to go thru several suspend/resume cycles
> without having the machine hanging while suspend !
I have to add a me too (HP 6730B, same PCI ids).
I was suffering from the same problem which seem completely gone with
the suggested hint.

R


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 |  Next  |  Last
Pages: 1 2
Prev: [PATCH mmotm] vmscan: raise the bar to PAGEOUT_IO_SYNC stalls
Next: [PATCH] arch/sparc/mm: Use GFP_KERNEL