Prev: [35/45] coredump: suppress uid comparison test if core output files are pipes
Next: [04/89] futex_lock_pi() key refcnt fix
From: Greg KH on 30 Mar 2010 20:40
2.6.27-stable review patch. If anyone has any objections, please let us know.

------------------


From: Thadeu Lima de Souza Cascardo <cascardo(a)holoscopio.com>

In Linus' tree:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c556752109794a5ff199b80a1673336b4df8433a

dev_dbg outputs dev_name, which is released with device_unregister. This bug
resulted in output like this:

i2c Xy2�0: adapter [SMBus I801 adapter at 1880] unregistered

The right output would be:
i2c i2c-0: adapter [SMBus I801 adapter at 1880] unregistered

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo(a)holoscopio.com>
Signed-off-by: Jean Delvare <khali(a)linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>

---
drivers/i2c/i2c-core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -644,6 +644,9 @@ int i2c_del_adapter(struct i2c_adapter *
}
}

+ /* device name is gone after device_unregister */
+ dev_dbg(&adap->dev, "adapter [%s] unregistered\n", adap->name);
+
/* clean up the sysfs representation */
init_completion(&adap->dev_released);
device_unregister(&adap->dev);
@@ -654,8 +657,6 @@ int i2c_del_adapter(struct i2c_adapter *
/* free bus id */
idr_remove(&i2c_adapter_idr, adap->nr);

- dev_dbg(&adap->dev, "adapter [%s] unregistered\n", adap->name);
-
/* Clear the device structure in case this adapter is ever going to be
added again */
memset(&adap->dev, 0, sizeof(adap->dev));


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [35/45] coredump: suppress uid comparison test if core output files are pipes
Next: [04/89] futex_lock_pi() key refcnt fix