Prev: DNS: Fixes for the DNS query module
Next: [00/34] 2.6.32.18-stable review
From: Greg KH on 6 Aug 2010 15:20
2.6.32-stable review patch. If anyone has any objections, please let us know.

------------------
[stable] [PATCH 2.6.32/stable] CIFS: Fix compile error with __init in cifs_init_dns_resolver() definition

From: Michael Neuling <mikey(a)neuling.org>

An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this error

fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'cifs_init_dns_resolver'

This adds the correct header file to fix this.

Signed-off-by: Michael Neuling <mikey(a)neuling.org>
Cc: David Howells <dhowells(a)redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>

---
fs/cifs/dns_resolve.h | 2 ++
1 file changed, 2 insertions(+)

--- a/fs/cifs/dns_resolve.h
+++ b/fs/cifs/dns_resolve.h
@@ -24,6 +24,8 @@
#define _DNS_RESOLVE_H

#ifdef __KERNEL__
+#include <linux/module.h>
+
extern int __init cifs_init_dns_resolver(void);
extern void cifs_exit_dns_resolver(void);
extern int dns_resolve_server_name_to_ip(const char *unc, char **ip_addr);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Michael Neuling on 6 Aug 2010 23:40


In message <20100806210619.GA5863(a)suse.de> you wrote:
> On Fri, Aug 06, 2010 at 09:53:17PM +0100, Ben Hutchings wrote:
> > On Fri, 2010-08-06 at 11:57 -0700, Greg KH wrote:
> > > 2.6.32-stable review patch. If anyone has any objections, please let us
know.
> > >
> > > ------------------
> > > [stable] [PATCH 2.6.32/stable] CIFS: Fix compile error with __init in ci
fs_init_dns_resolver() definition
> > >
> > > From: Michael Neuling <mikey(a)neuling.org>
> > >
> > > An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this erro
r
> > >
> > > fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attr
ibute__' before 'cifs_init_dns_resolver'
> > >
> > > This adds the correct header file to fix this.
> > [...]
> >
> > Why <linux/module.h> and not <linux/init.h>?
>
> Heh, it works :)
>
> Michael?

It's what David Howells wanted.....

http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-08/msg01316.html
(below as well)


> An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this error
>
> fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'cifs_init_dns_resolver'
>
> This removes the __init from cifs_init_dns_resolver()

That's not really a good idea as the assembler may choose different pieces of
assembly to do variable references and jumps, depending on the section
information.

A better fix is to add:

#include <linux/module.h>

to the header file.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: DNS: Fixes for the DNS query module
Next: [00/34] 2.6.32.18-stable review