Prev: [29/39] x86, amd: Check X86_FEATURE_OSVW bit before accessing OSVW MSRs
Next: [37/39] nilfs2: fix sync silent failure
From: Greg KH on 24 May 2010 19:30

2.6.33-stable review patch. If anyone has any objections, please let us know.

------------------
From: Dan Rosenberg <dan.j.rosenberg(a)gmail.com>

commit 5dc6416414fb3ec6e2825fd4d20c8bf1d7fe0395 upstream.

The existing code would have allowed you to clone a file that was
only open for writing

Signed-off-by: Chris Mason <chris.mason(a)oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>

---
fs/btrfs/ioctl.c | 5 +++++
1 file changed, 5 insertions(+)

--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -964,12 +964,17 @@ static noinline long btrfs_ioctl_clone(s
ret = -EBADF;
goto out_drop_write;
}
+
src = src_file->f_dentry->d_inode;

ret = -EINVAL;
if (src == inode)
goto out_fput;

+ /* the src must be open for reading */
+ if (!(src_file->f_mode & FMODE_READ))
+ goto out_fput;
+
ret = -EISDIR;
if (S_ISDIR(src->i_mode) || S_ISDIR(inode->i_mode))
goto out_fput;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [29/39] x86, amd: Check X86_FEATURE_OSVW bit before accessing OSVW MSRs
Next: [37/39] nilfs2: fix sync silent failure