Prev: [PATCH RFC 00/11] lock monitor: Separate features related to lock
Next: [PATCH, fix 1/2] Add the platform data include for the Xilinx XPS IIC Bus Interface
From: Sachin Sant on 14 Mar 2010 06:50
On a PowerPC box, latest 34-rc1 git(d89b218b8...) fails to build
with CGROUPS_MEM_RES_CTRL_SWAP=y.

LD init/built-in.o
LD .tmp_vmlinux1
mm/built-in.o: In function __xchg:
arch/powerpc/include/asm/system.h:331: undefined reference to .__xchg_called_with_bad_pointer
mm/built-in.o: In function __cmpxchg:
arch/powerpc/include/asm/system.h:474: undefined reference to .__cmpxchg_called_with_bad_pointer
make: *** [.tmp_vmlinux1] Error 1

The code in question was added via commit 024914477e...

memcg: move charges of anonymous swap

Thanks
-Sachin


--

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Michael Ellerman on 14 Mar 2010 21:10
On Sun, 2010-03-14 at 16:18 +0530, Sachin Sant wrote:
> On a PowerPC box, latest 34-rc1 git(d89b218b8...) fails to build
> with CGROUPS_MEM_RES_CTRL_SWAP=y.
>
> LD init/built-in.o
> LD .tmp_vmlinux1
> mm/built-in.o: In function __xchg:
> arch/powerpc/include/asm/system.h:331: undefined reference to .__xchg_called_with_bad_pointer
> mm/built-in.o: In function __cmpxchg:
> arch/powerpc/include/asm/system.h:474: undefined reference to .__cmpxchg_called_with_bad_pointer
> make: *** [.tmp_vmlinux1] Error 1
>
> The code in question was added via commit 024914477e...
>
> memcg: move charges of anonymous swap

struct swap_cgroup
{
unsigned short id;
};

+unsigned short swap_cgroup_cmpxchg(swp_entry_t ent,
+ unsigned short old, unsigned short new)
+{
....
+ struct swap_cgroup *sc;
....
+ if (cmpxchg(&sc->id, old, new) == old)


On powerpc cmpxchg() currently only handles u32 & u64.

cheers
 | 
Pages: 1
Prev: [PATCH RFC 00/11] lock monitor: Separate features related to lock
Next: [PATCH, fix 1/2] Add the platform data include for the Xilinx XPS IIC Bus Interface