Prev: net/caif: Use kzalloc
Next: [PATCH 1/2] perf newt: Make <- exit the ui_browser
From: Benjamin Herrenschmidt on 15 May 2010 19:50
On Fri, 2010-05-14 at 21:44 +0400, Sergei Shtylyov wrote:
> Hello.
>
> Rupjyoti Sarmah wrote:
>
> > This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX.
> >
> > Signed-off-by: Rupjyoti Sarmah <rsarmah(a)appliedmicro.com>
> > Signed-off-by: Mark Miesfeld <mmiesfeld(a)appliedmicro.com>
> > Signed-off-by: Prodyut Hazarika <phazarika(a)appliedmicro.com>
> > ---
> > arch/powerpc/boot/dts/canyonlands.dts | 8 +
> > drivers/ata/Kconfig | 9 +
> > drivers/ata/Makefile | 1 +
> > drivers/ata/sata_dwc.c | 1827 +++++++++++++++++++++++++++++++++
> > 4 files changed, 1845 insertions(+), 0 deletions(-)
> > create mode 100644 drivers/ata/sata_dwc.c
> >
> > diff --git a/arch/powerpc/boot/dts/canyonlands.dts b/arch/powerpc/boot/dts/canyonlands.dts
> > index cd56bb5..d3b2c99 100644
> > --- a/arch/powerpc/boot/dts/canyonlands.dts
> > +++ b/arch/powerpc/boot/dts/canyonlands.dts
> > @@ -163,6 +163,14 @@
> > interrupts = <0x1e 4>;
> > };
> >
> > + SATA0: sata(a)bffd1000 {
> > + compatible = "amcc,sata-460ex";
> > + reg = <4 0xbffd1000 0x800 4 0xbffd0800 0x400>;
> > + interrupt-parent = <&UIC3>;
> > + interrupts = <0x0 0x4 /* SATA */
> > + 0x5 0x4>; /* AHBDMA */
> > + };
> > +
> > POB0: opb {
> > compatible = "ibm,opb-460ex", "ibm,opb";
> > #address-cells = <1>;
> >
>
> Please put the device tree update in a separate patch to go thru the
> PowerPC tree.

Additionally, the boot wrapper should probably either remove the node or
at least use a status property "ok" / "disabled" to represent whether
the board is configured for SATA or PCIe x1...

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Benjamin Herrenschmidt on 17 May 2010 06:40

> > Additionally, the boot wrapper should probably either remove the node or
> > at least use a status property "ok" / "disabled" to represent whether
> > the board is configured for SATA or PCIe x1...
>
> U-Boot already sets the "status" property of the PCIe or SATA node
> accordingly. Just let me know if this doesn't work for you.

That's probably enough.

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: net/caif: Use kzalloc
Next: [PATCH 1/2] perf newt: Make <- exit the ui_browser