Prev: [PATCH 4/5] arm: omap: remove the unused omap_gpio_set_debounce methods
Next: [PATCH 3/5] arm: omap: switch over to gpio_set_debounce
From: Stefan Roese on 17 May 2010 06:10
Hi Ben,

On Sunday 16 May 2010 01:40:28 Benjamin Herrenschmidt wrote:
> > > + SATA0: sata(a)bffd1000 {
> > > + compatible = "amcc,sata-460ex";
> > > + reg = <4 0xbffd1000 0x800 4 0xbffd0800 0x400>;
> > > + interrupt-parent = <&UIC3>;
> > > + interrupts = <0x0 0x4 /* SATA */
> > > + 0x5 0x4>; /* AHBDMA */
> > > + };
> > > +
> > >
> > > POB0: opb {
> > >
> > > compatible = "ibm,opb-460ex", "ibm,opb";
> > > #address-cells = <1>;
> >
> > Please put the device tree update in a separate patch to go thru the
> >
> > PowerPC tree.
>
> Additionally, the boot wrapper should probably either remove the node or
> at least use a status property "ok" / "disabled" to represent whether
> the board is configured for SATA or PCIe x1...

U-Boot already sets the "status" property of the PCIe or SATA node
accordingly. Just let me know if this doesn't work for you.

Cheers,
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jassi Brar on 18 May 2010 22:00
On Thu, May 6, 2010 at 2:57 AM, Rupjyoti Sarmah <rsarmah(a)amcc.com> wrote:
> This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX.

The controller seems to be a thrid party IP (from Synopsys) in your
SoC and there are many chances the IP will appear in some other
SOCs too. This implementation doesn't seem to take care of that
scenario.
So, please either call the driver something like sata_460ex.c
or, better still, segregate the driver in two parts - SoC specific stuff
and DWC IP core driver that can be reused by other SoCs having the
same IP in future.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Jassi Brar on 19 May 2010 07:20
On Wed, May 19, 2010 at 6:53 PM, Alan Cox <alan(a)lxorguk.ukuu.org.uk> wrote:
> On Wed, 19 May 2010 10:49:59 +0900
> Jassi Brar <jassisinghbrar(a)gmail.com> wrote:
>
>> On Thu, May 6, 2010 at 2:57 AM, Rupjyoti Sarmah <rsarmah(a)amcc.com> wrote:
>> > This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX.
>>
>> The controller seems to be a thrid party IP (from Synopsys) in your
>> SoC and there are many chances the IP will appear in some other
>> SOCs too. This implementation doesn't seem to take care of that
>> scenario.
>
> I'd question if that is worth it seriously. At the point there are
> multiple users of the device you know what it will look like. Until then
> you neither know if the work is needed nor what will require abstracting.
Well, am to start writing driver for some dwc sata core in near
future, not sure of the
exact version because I've not yet had my hands on the specs.
Even if my version happens to be different, we don't wanna count on such odds.
So I believe it's worthwhile.

Btw, I presented two options and the author can always choose the
first one - rename
the driver as SoC specific. And in a way, I'd prefer that :)

> Lazy evaluation is good for code too ;)
Apart from increasing re-usability, that POV brings out neat code too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 4/5] arm: omap: remove the unused omap_gpio_set_debounce methods
Next: [PATCH 3/5] arm: omap: switch over to gpio_set_debounce