Prev: linux-next: build failure after merge of the driver-core tree
Next: [PATCH] Netfilter: Remove unused headers in net/netfilter/nfnetlink.c
From: Stephen Rothwell on 17 Mar 2010 01:10
Hi,

Just a couple of quick points ...

On Tue, 16 Mar 2010 21:23:16 -0700 "Rupjyoti Sarmah" <rsarmah(a)amcc.com> wrote:
>
> This patch enables the on-chip DWC SATA controller of the AppliedMicro
> processor 460EX.
>
> Signed-off-by: Rupjyoti Sarmah <rsarmah(a)appliedmicro.com> ,Mark Miesfeld
> <mmiesfeld(a)appliedmicro.com>,
> Prodyut Hazarika <phazarika(a)appliedmicro.com>

Please put one Signed-off-by line per person.

> ---
> arch/powerpc/boot/dts/canyonlands.dts | 8 +
> drivers/ata/Kconfig | 9 +
> drivers/ata/Makefile | 1 +
> drivers/ata/sata_dwc.c | 1965
> +++++++++++++++++++++++++++++++++
> 4 files changed, 1983 insertions(+), 0 deletions(-)
> create mode 100644 drivers/ata/sata_dwc.c

This patch has been word wrapped by your mailer (or something along the
way).
--
Cheers,
Stephen Rothwell sfr(a)canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Jeff Garzik on 17 Mar 2010 16:20
On 03/17/2010 08:03 AM, Stefan Roese wrote:
> Hi Rup,
>
> On Wednesday 17 March 2010 05:23:16 Rupjyoti Sarmah wrote:
>> This patch enables the on-chip DWC SATA controller of the AppliedMicro
>> processor 460EX.
>
> Apart from the other comments, did you take a look at the latest version of
> this driver in our linux-2.6-denx repository? We did some work on this driver
> for a new Canyonlands release last year. It's hard to check this for me now,
> with this line wrapped patch (the drivers diverged somewhat). So either check
> for yourself, or send a new, not line-wrapped, patch version so that I can
> better check myself.
>
> BTW: It would be nice if you would add me to Cc on DWC-SATA related patches,
> since I've been involved in the development at some time.

I will wait for Rupjyoti to check the linux-2.6-denx repo, and resend
the patches without word wrapping.

Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: linux-next: build failure after merge of the driver-core tree
Next: [PATCH] Netfilter: Remove unused headers in net/netfilter/nfnetlink.c