68328serial: check return value of copy_*_user() instead of access_ok()
in [Kernel]
|
Prev: act_nat: the checksum of ICMP doesn't have pseudo header
Next: [PATCH 1/7 v2] 68328serial: check return value of copy_*_user() instead of access_ok()
From: Vasiliy Kulikov on 1 Aug 2010 02:20 On Sat, Jul 31, 2010 at 21:09 +0200, Dan Carpenter wrote: > On Sat, Jul 31, 2010 at 09:38:00PM +0400, Kulikov Vasiliy wrote: > > - sizeof(struct m68k_serial))) > > - return -EFAULT; > > - copy_to_user((struct m68k_serial *) arg, > > + return copy_to_user((struct m68k_serial *) arg, > > info, sizeof(struct m68k_serial)); > > We should return if -EFAULT copy_to_user() failes here. Right, I was looking for this bug and made it myself :) Thank you. > > > - return 0; > > - > > default: > > return -ENOIOCTLCMD; > > } > > Smatch would have caught that but I don't have a cross compile > environment set up. > > regards, > dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |