Prev: [59/98] libata: Fix accesses at LBA28 boundary (old bug, but nasty) (v2)
Next: [82/98] security: testing the wrong variable in create_by_name()
From: Greg KH on 10 May 2010 19:10
2.6.32-stable review patch. If anyone has any objections, please let us know.

------------------

From: Bjørn Mork <bjorn(a)mork.no>

commit 6f550dc08369ee0bc6402963c377e65f0f2e3b71 upstream.

Never call dvb_frontend_detach if we failed to attach a frontend. This fixes
the following oops, which will be triggered by a missing stv090x module:

[ 8.172997] DVB: registering new adapter (TT-Budget S2-1600 PCI)
[ 8.209018] adapter has MAC addr = 00:d0:5c:cc:a7:29
[ 8.328665] Intel ICH 0000:00:1f.5: PCI INT B -> GSI 17 (level, low) -> IRQ 17
[ 8.328753] Intel ICH 0000:00:1f.5: setting latency timer to 64
[ 8.562047] DVB: Unable to find symbol stv090x_attach()
[ 8.562117] BUG: unable to handle kernel NULL pointer dereference at 000000ac
[ 8.562239] IP: [<e08b04a3>] dvb_frontend_detach+0x4/0x67 [dvb_core]

Ref http://bugs.debian.org/575207

Signed-off-by: Bjørn Mork <bjorn(a)mork.no>
Signed-off-by: Mauro Carvalho Chehab <mchehab(a)redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh(a)suse.de>

---
drivers/media/dvb/ttpci/budget.c | 3 ---
1 file changed, 3 deletions(-)

--- a/drivers/media/dvb/ttpci/budget.c
+++ b/drivers/media/dvb/ttpci/budget.c
@@ -643,9 +643,6 @@ static void frontend_init(struct budget
&budget->i2c_adap,
&tt1600_isl6423_config);

- } else {
- dvb_frontend_detach(budget->dvb_frontend);
- budget->dvb_frontend = NULL;
}
}
break;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [59/98] libata: Fix accesses at LBA28 boundary (old bug, but nasty) (v2)
Next: [82/98] security: testing the wrong variable in create_by_name()