From: Thomas Renninger on
On Monday 02 August 2010 09:48:25 Huang Ying wrote:
> This patch adds debugging/testing support to ERST. A misc device is
> implemented to export raw ERST read/write/clear etc operations to user
> space. With this patch, we can add ERST testing support to
> linuxfirmwarekit ISO (linuxfirmwarekit.org) to verify the kernel
> support and the firmware implementation.

Shouldn't this show up in debugfs?

Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Huang Ying on
On Thu, 2010-08-05 at 16:27 +0800, Thomas Renninger wrote:
> On Monday 02 August 2010 09:48:25 Huang Ying wrote:
> > This patch adds debugging/testing support to ERST. A misc device is
> > implemented to export raw ERST read/write/clear etc operations to user
> > space. With this patch, we can add ERST testing support to
> > linuxfirmwarekit ISO (linuxfirmwarekit.org) to verify the kernel
> > support and the firmware implementation.
>
> Shouldn't this show up in debugfs?

We do not do that because we want to export some "raw" operations of
ERST to user space, and using the interface in some automated testing
program in linuxfirmwarekit. That is, this is a interface mostly for
machine but human.

Best Regards,
Huang Ying


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Len Brown on
applied

thanks,
Len Brown, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on
On 08/10/10 18:37, Huang Ying wrote:
> Hi, Len,
>
> There is build error on i386 in the previous version. This new version fixed
> it, please replace it in acpi-test.git.
>
> Best Regards,
> Huang Ying
> ------------------------------->
> This patch adds debugging/testing support to ERST. A misc device is
> implemented to export raw ERST read/write/clear etc operations to user
> space. With this patch, we can add ERST testing support to
> linuxfirmwarekit ISO (linuxfirmwarekit.org) to verify the kernel
> support and the firmware implementation.
>
> v2:
>
> - Fix build error on i386
>
> Signed-off-by: Huang Ying <ying.huang(a)intel.com>
> Signed-off-by: Andi Kleen <ak(a)linux.intel.com>
> ---
> drivers/acpi/apei/Kconfig | 9 +
> drivers/acpi/apei/Makefile | 1
> drivers/acpi/apei/erst-dbg.c | 207 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 217 insertions(+)
> create mode 100644 drivers/acpi/apei/erst-dbg.c

A patch against linux-next (or some acpi tree) would have been better
for testing, but anyway, I fixed that little problem.

Acked-by: Randy Dunlap <randy.dunlap(a)oracle.com>

Thanks.

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Randy Dunlap on
On 08/11/10 20:55, Huang Ying wrote:
> Hi, Len,
>
> This is v3 of ERST debug support patch, fixes i386 build error and
> warning. Please replace it in acpi-test.git.
>
> Best Regards,
> Huang Ying
> -------------------------------------------->
> This patch adds debugging/testing support to ERST. A misc device is
> implemented to export raw ERST read/write/clear etc operations to user
> space. With this patch, we can add ERST testing support to
> linuxfirmwarekit ISO (linuxfirmwarekit.org) to verify the kernel
> support and the firmware implementation.
>
>
> v3:
>
> - Fix ssize_t printk format string instead of cast.
>
> v2:
>
> - Fix build error on i386
>
> Signed-off-by: Huang Ying <ying.huang(a)intel.com>
> Signed-off-by: Andi Kleen <ak(a)linux.intel.com>
> ---
> drivers/acpi/apei/Kconfig | 9 +
> drivers/acpi/apei/Makefile | 1
> drivers/acpi/apei/erst-dbg.c | 207 +++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 217 insertions(+)
> create mode 100644 drivers/acpi/apei/erst-dbg.c


Works for me. Thanks.

Acked-by: Randy Dunlap <randy.dunlap(a)oracle.com>


--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/