From: Jesse Barnes on
On Mon, 15 Mar 2010 21:32:41 +0200
Surbhi Palande <surbhi.palande(a)canonical.com> wrote:

> The following two patches are quirks that blacklist bios which report
> incorrect lid status. These are bioses for machines with a 900 GM.
> The first one is tested by Ubuntu users and the second one isn't.
> Further testing will be appreciated.
>
>
> Surbhi Palande (2):
> drm/i915: blacklist lid status: Sony VGN-BX196VP
> drm/i915: blacklist lid status: Elite Co. G335
>
> drivers/gpu/drm/i915/intel_lvds.c | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)

Patches look ok to me. Len was curious about whether some recent ACPI
EC fixes will fix some of our lid detection bugs though.

Len, is there any particular patch or version people should try?

Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Eric Anholt on
On Fri, 19 Mar 2010 12:53:20 -0700, Jesse Barnes <jbarnes(a)virtuousgeek.org> wrote:
> On Mon, 15 Mar 2010 21:32:41 +0200
> Surbhi Palande <surbhi.palande(a)canonical.com> wrote:
>
> > The following two patches are quirks that blacklist bios which report
> > incorrect lid status. These are bioses for machines with a 900 GM.
> > The first one is tested by Ubuntu users and the second one isn't.
> > Further testing will be appreciated.
> >
> >
> > Surbhi Palande (2):
> > drm/i915: blacklist lid status: Sony VGN-BX196VP
> > drm/i915: blacklist lid status: Elite Co. G335
> >
> > drivers/gpu/drm/i915/intel_lvds.c | 14 ++++++++++++++
> > 1 files changed, 14 insertions(+), 0 deletions(-)
>
> Patches look ok to me. Len was curious about whether some recent ACPI
> EC fixes will fix some of our lid detection bugs though.
>
> Len, is there any particular patch or version people should try?

Unless ACPI is going to magically become more reliable at the lid
method, I think we should abandon using it on generations where it
fails. See other patch I submitted -- anyone care to ack it?
From: Jesse Barnes on
On Fri, 19 Mar 2010 13:53:10 -0700
Eric Anholt <eric(a)anholt.net> wrote:

> On Fri, 19 Mar 2010 12:53:20 -0700, Jesse Barnes <jbarnes(a)virtuousgeek.org> wrote:
> > On Mon, 15 Mar 2010 21:32:41 +0200
> > Surbhi Palande <surbhi.palande(a)canonical.com> wrote:
> >
> > > The following two patches are quirks that blacklist bios which report
> > > incorrect lid status. These are bioses for machines with a 900 GM.
> > > The first one is tested by Ubuntu users and the second one isn't.
> > > Further testing will be appreciated.
> > >
> > >
> > > Surbhi Palande (2):
> > > drm/i915: blacklist lid status: Sony VGN-BX196VP
> > > drm/i915: blacklist lid status: Elite Co. G335
> > >
> > > drivers/gpu/drm/i915/intel_lvds.c | 14 ++++++++++++++
> > > 1 files changed, 14 insertions(+), 0 deletions(-)
> >
> > Patches look ok to me. Len was curious about whether some recent ACPI
> > EC fixes will fix some of our lid detection bugs though.
> >
> > Len, is there any particular patch or version people should try?
>
> Unless ACPI is going to magically become more reliable at the lid
> method, I think we should abandon using it on generations where it
> fails. See other patch I submitted -- anyone care to ack it?

Well, that was the hope. Len said they've fixed EC bugs in the past
only to find that several ACPI methods they assumed were broken
suddenly started working....

--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Matthew Garrett on
On Fri, Mar 19, 2010 at 02:05:03PM -0700, Jesse Barnes wrote:

> Well, that was the hope. Len said they've fixed EC bugs in the past
> only to find that several ACPI methods they assumed were broken
> suddenly started working....

The broken Acer was reading from the wrong registers. I think that's
pretty strong evidence that Windows doesn't depend on lid state,
unfortunately.

--
Matthew Garrett | mjg59(a)srcf.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/