ACPI patches for 2.6.34-rc6
in [Kernel]
|
Prev: [PATCH 0/2] net-next/fec: bug fixing after introduced phylib supporting
Next: [PATCH] Check kmalloc return value before use the buffer
From: Matthew Garrett on 11 May 2010 14:00 On Tue, May 11, 2010 at 10:42:52AM -0700, Linus Torvalds wrote: > Maybe windows does something else? Or do you _see_ windows doing that > write? I see Windows write the SCI_EN bit without reading it first and without calling the ACPI enable SMM function. > will write it _even_if_ the bit was already set. That could explain > Rafael's problems too - writing the register directly may be the > RightThing(tm), but writing it if the bit was already set may well cause > some confusion. Like I said, I don't see any reads on resume - only on system boot. -- Matthew Garrett | mjg59(a)srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Linus Torvalds on 11 May 2010 14:30 On Tue, 11 May 2010, Matthew Garrett wrote: > > I see Windows write the SCI_EN bit without reading it first and without > calling the ACPI enable SMM function. Hmm. So presumably Windows doesn't even do them bit-by-bit, but simply does a "restore PM1 Control register value" on resume. And I guess it probably does the same for the PM1_ENABLE register and the PM2 control registers too? Just restoring the whole register values _does_ sound a lot simpler than worrying about individual bits. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Matthew Garrett on 11 May 2010 14:30
On Tue, May 11, 2010 at 11:17:34AM -0700, Linus Torvalds wrote: > > > On Tue, 11 May 2010, Matthew Garrett wrote: > > > > I see Windows write the SCI_EN bit without reading it first and without > > calling the ACPI enable SMM function. > > Hmm. So presumably Windows doesn't even do them bit-by-bit, but simply > does a "restore PM1 Control register value" on resume. Yup. > And I guess it probably does the same for the PM1_ENABLE register and the > PM2 control registers too? Haven't checked those, but could do so easily enough. (I say easily enough. Turns out that getting Windows to do S3 under qemu is a fair amount of work) -- Matthew Garrett | mjg59(a)srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |