From: Nigel Cunningham on
Hi Greg et al.

On 11/05/10 08:32, Greg KH wrote:
> 2.6.33-stable review patch. If anyone has any objections, please let us know.
>
> ------------------
>
> From: Daniel T Chen<crimsun(a)ubuntu.com>
>
> commit 5c1bccf645d4ab65e4c7502acb42e8b9afdb5bdc upstream.
>
> BugLink: https://launchpad.net/bugs/568600
>
> The OR has verified that the dell-m6 model quirk is necessary for audio
> to be audible by default on the Dell Studio XPS 1645.

Just that the commit comment doesn't match the code here.

Regards,

Nigel

> This change is necessary for 2.6.32.11 and 2.6.33.2 alike.
>
> Reported-by: Andy Ross<andy(a)plausible.org>
> Tested-by: Andy Ross<andy(a)plausible.org>
> Signed-off-by: Daniel T Chen<crimsun(a)ubuntu.com>
> Signed-off-by: Takashi Iwai<tiwai(a)suse.de>
> Signed-off-by: Greg Kroah-Hartman<gregkh(a)suse.de>
>
> ---
> sound/pci/hda/patch_sigmatel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -1604,6 +1604,8 @@ static struct snd_pci_quirk stac92hd73xx
> "Dell Studio 1557", STAC_DELL_M6_DMIC),
> SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x02fe,
> "Dell Studio XPS 1645", STAC_DELL_M6_BOTH),
> + SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0413,
> + "Dell Studio 1558", STAC_DELL_M6_BOTH),
> {} /* terminator */
> };
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo(a)vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Nigel Cunningham on
Hi again.

On 11/05/10 08:35, Greg KH wrote:
> 2.6.32-stable review patch. If anyone has any objections, please let us know.
>
> ------------------
>
> From: Daniel T Chen<crimsun(a)ubuntu.com>
>
> commit 5c1bccf645d4ab65e4c7502acb42e8b9afdb5bdc upstream.
>
> BugLink: https://launchpad.net/bugs/568600
>
> The OR has verified that the dell-m6 model quirk is necessary for audio
> to be audible by default on the Dell Studio XPS 1645.

My previous comment (commit message doesn't match code) applies here too.

Regards,

Nigel

> This change is necessary for 2.6.32.11 and 2.6.33.2 alike.
>
> Reported-by: Andy Ross<andy(a)plausible.org>
> Tested-by: Andy Ross<andy(a)plausible.org>
> Signed-off-by: Daniel T Chen<crimsun(a)ubuntu.com>
> Signed-off-by: Takashi Iwai<tiwai(a)suse.de>
> Signed-off-by: Greg Kroah-Hartman<gregkh(a)suse.de>
>
> ---
> sound/pci/hda/patch_sigmatel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- a/sound/pci/hda/patch_sigmatel.c
> +++ b/sound/pci/hda/patch_sigmatel.c
> @@ -1594,6 +1594,8 @@ static struct snd_pci_quirk stac92hd73xx
> "Dell Studio 1557", STAC_DELL_M6_DMIC),
> SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x02fe,
> "Dell Studio XPS 1645", STAC_DELL_M6_BOTH),
> + SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0413,
> + "Dell Studio 1558", STAC_DELL_M6_BOTH),
> {} /* terminator */
> };
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo(a)vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/