Prev: [PATCH 0/5] PEBS and LBR fixes
Next: [PATCH 4/5] perf, x86: Clear the LBRs on init
From: Takashi Iwai on 5 Mar 2010 10:50
At Fri, 5 Mar 2010 16:34:31 +0100,
Frederik Deweerdt wrote:
>
> Hello Takashi,
>
> Commit eaa9b3a748539651f50e3a234c8854e1b42a839a introduced the following
> uninitialized warning:
>
> sound/pci/hda/patch_realtek.c: In function 'set_capture_mixer':
> sound/pci/hda/patch_realtek.c:4928: warning: 'pin' is used uninitialized in this function
> sound/pci/hda/patch_realtek.c:4918: note: 'pin' was declared here
>
> It appears indeed that 'pin' needs to be initialized to 0.
>
> Signed-off-by: Frederik Deweerdt <frederik.deweerdt(a)gmail.com>

Thanks, applied now.


Takashi


> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index e8cbe21..5c89242 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4915,7 +4915,7 @@ static void fixup_automic_adc(struct hda_codec *codec)
> static void fixup_single_adc(struct hda_codec *codec)
> {
> struct alc_spec *spec = codec->spec;
> - hda_nid_t pin;
> + hda_nid_t pin = 0;
> int i;
>
> /* search for the input pin; there must be only one */
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 0/5] PEBS and LBR fixes
Next: [PATCH 4/5] perf, x86: Clear the LBRs on init