Prev: [PATCH] tcp: cookie transactions setsockopt memory leak
Next: [PATCH 3/5] writeback: prevent sync livelock with the sync_after timestamp
From: Takashi Iwai on 29 Jul 2010 08:10
At Thu, 29 Jul 2010 14:45:24 +0400,
Kulikov Vasiliy wrote:
>
> request_region() may fail, if so return -EBUSY.
>
> Signed-off-by: Kulikov Vasiliy <segooon(a)gmail.com>

Thanks, applied both patches now.


Takashi

> ---
> sound/isa/msnd/msnd_pinnacle.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/sound/isa/msnd/msnd_pinnacle.c b/sound/isa/msnd/msnd_pinnacle.c
> index 60b6abd..ed42f8e 100644
> --- a/sound/isa/msnd/msnd_pinnacle.c
> +++ b/sound/isa/msnd/msnd_pinnacle.c
> @@ -549,7 +549,10 @@ static int __devinit snd_msnd_attach(struct snd_card *card)
> printk(KERN_ERR LOGNAME ": Couldn't grab IRQ %d\n", chip->irq);
> return err;
> }
> - request_region(chip->io, DSP_NUMIO, card->shortname);
> + if (request_region(chip->io, DSP_NUMIO, card->shortname) == NULL) {
> + free_irq(chip->irq, chip);
> + return -EBUSY;
> + }
>
> if (!request_mem_region(chip->base, BUFFSIZE, card->shortname)) {
> printk(KERN_ERR LOGNAME
> --
> 1.7.0.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] tcp: cookie transactions setsockopt memory leak
Next: [PATCH 3/5] writeback: prevent sync livelock with the sync_after timestamp