Prev: NFS: Fix build failure on !CONFIG_NFS_V3 && !CONFIG_NFS_V3
Next: jz4740-adc: fix resource reclaim in jz4740_adc_probe error path
From: avictor.za on 1 Aug 2010 17:30
hi,

> cam60_spi_devices is passed to at91_add_device_spi which calls
> spi_register_board_info. �The latter makes a copy of it, so living in
> .init.data is OK.

The copy still maintains a pointers to
"cam60_spi_flash_platform_data", so I'm wondering if that and
"cam60_spi_partitions" should maybe not be marked as __initdata.


Regards,
Andrew Victor



> ---
> �arch/arm/mach-at91/board-cam60.c | � �4 ++--
> �1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-at91/board-cam60.c b/arch/arm/mach-at91/board-cam60.c
> index 02138af..05c7072 100644
> --- a/arch/arm/mach-at91/board-cam60.c
> +++ b/arch/arm/mach-at91/board-cam60.c
> @@ -98,14 +98,14 @@ static struct mtd_partition __initdata cam60_spi_partitions[] = {
> � � � �},
> �};
>
> -static struct flash_platform_data __initdata cam60_spi_flash_platform_data = {
> +static struct flash_platform_data cam60_spi_flash_platform_data __initdata = {
> � � � �.name � � � � � = "spi_flash",
> � � � �.parts � � � � �= cam60_spi_partitions,
> � � � �.nr_parts � � � = ARRAY_SIZE(cam60_spi_partitions)
> �};
> �#endif
>
> -static struct spi_board_info cam60_spi_devices[] = {
> +static struct spi_board_info cam60_spi_devices[] __initdata = {
> �#if defined(CONFIG_MTD_DATAFLASH)
> � � � �{ � � � /* DataFlash chip */
> � � � � � � � �.modalias � � � = "mtd_dataflash",
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Uwe Kleine-König on 2 Aug 2010 01:30
Hi Andrew,

On Sun, Aug 01, 2010 at 11:23:35PM +0200, avictor.za(a)gmail.com wrote:
> > cam60_spi_devices is passed to at91_add_device_spi which calls
> > spi_register_board_info. �The latter makes a copy of it, so living in
> > .init.data is OK.
>
> The copy still maintains a pointers to
> "cam60_spi_flash_platform_data", so I'm wondering if that and
> "cam60_spi_partitions" should maybe not be marked as __initdata.
I think that's right, these need to be fixed up. Thanks for noticing, I
will prepare a patch later today.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K�nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: NFS: Fix build failure on !CONFIG_NFS_V3 && !CONFIG_NFS_V3
Next: jz4740-adc: fix resource reclaim in jz4740_adc_probe error path