ARM/nuc900: fix nuc900 touchscreen clk definition bug
in [Kernel]
|
Prev: you have just exceeded your Email Quota limit
Next: net-next: fix LRO feature update in vmxnet3
From: Marek Vasut on 16 Jul 2010 01:10 Dne Pá 16. července 2010 05:03:27 Wan ZongShun napsal(a): > This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's > name should be 'nuc900-ts', it should be the same to pdev.name. or else, > the touchscreen driver will be not working well due to clock engine > disabled. > > Signed-off-by: Wan ZongShun <mcuos.com(a)gmail.com> > --- > arch/arm/mach-w90x900/cpu.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c > index 642207e..83c5632 100644 > --- a/arch/arm/mach-w90x900/cpu.c > +++ b/arch/arm/mach-w90x900/cpu.c > @@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = { > DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL), > DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL), > DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL), > - DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL), > + DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL), > DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL), > DEF_CLKLOOK(&clk_ext, NULL, "ext"), > DEF_CLKLOOK(&clk_timer0, NULL, "timer0"), Hey, Is that thing really touchscreen or general-purpose analog/digital converter ? Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Wan ZongShun on 16 Jul 2010 01:40 2010/7/16 Marek Vasut <marek.vasut(a)gmail.com>: > Dne Pá 16. července 2010 05:03:27 Wan ZongShun napsal(a): >> This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's >> name should be 'nuc900-ts', it should be the same to pdev.name. or else, >> the touchscreen driver will be not working well due to clock engine >> disabled. >> >> Signed-off-by: Wan ZongShun <mcuos.com(a)gmail.com> >> --- >> arch/arm/mach-w90x900/cpu.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c >> index 642207e..83c5632 100644 >> --- a/arch/arm/mach-w90x900/cpu.c >> +++ b/arch/arm/mach-w90x900/cpu.c >> @@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = { >> DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL), >> DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL), >> DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL), >> - DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL), >> + DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL), >> DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL), >> DEF_CLKLOOK(&clk_ext, NULL, "ext"), >> DEF_CLKLOOK(&clk_timer0, NULL, "timer0"), > > Hey, > > Is that thing really touchscreen or general-purpose analog/digital converter ? > Oh, it is general-purpose analog/digital converter controller. I only use it to implemnt my touchscreen function, Also it can be use other function. so, I have to change my touchscreen driver name to nuc900-adc? Thanks for your Reminder, I appreciate it. :) > Cheers > -- *linux-arm-kernel mailing list mail addr:linux-arm-kernel(a)lists.infradead.org you can subscribe by: http://lists.infradead.org/mailman/listinfo/linux-arm-kernel * linux-arm-NUC900 mailing list mail addr:NUC900(a)googlegroups.com main web: https://groups.google.com/group/NUC900 you can subscribe it by sending me mail: mcuos.com(a)gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Marek Vasut on 16 Jul 2010 03:20 Dne Pá 16. července 2010 07:34:21 Wan ZongShun napsal(a): > 2010/7/16 Marek Vasut <marek.vasut(a)gmail.com>: > > Dne Pá 16. července 2010 05:03:27 Wan ZongShun napsal(a): > >> This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's > >> name should be 'nuc900-ts', it should be the same to pdev.name. or else, > >> the touchscreen driver will be not working well due to clock engine > >> disabled. > >> > >> Signed-off-by: Wan ZongShun <mcuos.com(a)gmail.com> > >> --- > >> arch/arm/mach-w90x900/cpu.c | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c > >> index 642207e..83c5632 100644 > >> --- a/arch/arm/mach-w90x900/cpu.c > >> +++ b/arch/arm/mach-w90x900/cpu.c > >> @@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = { > >> DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL), > >> DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL), > >> DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL), > >> - DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL), > >> + DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL), > >> DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL), > >> DEF_CLKLOOK(&clk_ext, NULL, "ext"), > >> DEF_CLKLOOK(&clk_timer0, NULL, "timer0"), > > > > Hey, > > > > Is that thing really touchscreen or general-purpose analog/digital > > converter ? > > Oh, it is general-purpose analog/digital converter controller. > I only use it to implemnt my touchscreen function, Also it can be use > other function. > > so, I have to change my touchscreen driver name to nuc900-adc? No, just change the name of clock in the touchscreen driver. So that the touchscreen driver will use nuc900-adc clocksource. You're welcome. :) > > Thanks for your Reminder, I appreciate it. :) > > > Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Wan ZongShun on 16 Jul 2010 05:20 2010/7/16 Marek Vasut <marek.vasut(a)gmail.com>: > Dne Pá 16. července 2010 07:34:21 Wan ZongShun napsal(a): >> 2010/7/16 Marek Vasut <marek.vasut(a)gmail.com>: >> > Dne Pá 16. července 2010 05:03:27 Wan ZongShun napsal(a): >> >> This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's >> >> name should be 'nuc900-ts', it should be the same to pdev.name. or else, >> >> the touchscreen driver will be not working well due to clock engine >> >> disabled. >> >> >> >> Signed-off-by: Wan ZongShun <mcuos.com(a)gmail.com> >> >> --- >> >> arch/arm/mach-w90x900/cpu.c | 2 +- >> >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> >> >> diff --git a/arch/arm/mach-w90x900/cpu.c b/arch/arm/mach-w90x900/cpu.c >> >> index 642207e..83c5632 100644 >> >> --- a/arch/arm/mach-w90x900/cpu.c >> >> +++ b/arch/arm/mach-w90x900/cpu.c >> >> @@ -93,7 +93,7 @@ static struct clk_lookup nuc900_clkregs[] = { >> >> DEF_CLKLOOK(&clk_kpi, "nuc900-kpi", NULL), >> >> DEF_CLKLOOK(&clk_wdt, "nuc900-wdt", NULL), >> >> DEF_CLKLOOK(&clk_gdma, "nuc900-gdma", NULL), >> >> - DEF_CLKLOOK(&clk_adc, "nuc900-adc", NULL), >> >> + DEF_CLKLOOK(&clk_adc, "nuc900-ts", NULL), >> >> DEF_CLKLOOK(&clk_usi, "nuc900-spi", NULL), >> >> DEF_CLKLOOK(&clk_ext, NULL, "ext"), >> >> DEF_CLKLOOK(&clk_timer0, NULL, "timer0"), >> > >> > Hey, >> > >> > Is that thing really touchscreen or general-purpose analog/digital >> > converter ? >> >> Oh, it is general-purpose analog/digital converter controller. >> I only use it to implemnt my touchscreen function, Also it can be use >> other function. >> >> so, I have to change my touchscreen driver name to nuc900-adc? > > No, just change the name of clock in the touchscreen driver. So that the > touchscreen driver will use nuc900-adc clocksource. But the clk_get() identifies this clk via looking driver or pdev name. so I must change my touchscreen driver name, right? > > You're welcome. :) > >> >> Thanks for your Reminder, I appreciate it. :) >> >> > Cheers > -- *linux-arm-kernel mailing list mail addr:linux-arm-kernel(a)lists.infradead.org you can subscribe by: http://lists.infradead.org/mailman/listinfo/linux-arm-kernel * linux-arm-NUC900 mailing list mail addr:NUC900(a)googlegroups.com main web: https://groups.google.com/group/NUC900 you can subscribe it by sending me mail: mcuos.com(a)gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Russell King - ARM Linux on 18 Jul 2010 05:10 On Fri, Jul 16, 2010 at 11:03:27AM +0800, Wan ZongShun wrote: > This patch is to fix nuc900 touchscreen clk definition bug,the .dev_id's > name should be 'nuc900-ts', it should be the same to pdev.name. or else, > the touchscreen driver will be not working well due to clock engine disabled. Ok. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|
Pages: 1 Prev: you have just exceeded your Email Quota limit Next: net-next: fix LRO feature update in vmxnet3 |