Add a WARN() macro; this is WARN_ON() + printk arguments
in [Kernel]
|
Prev: Reverting per-cpuset "system" (IRQ affinity) patch (was: Fix cpuset sched_relax_domain_level control file)
Next: BUG: unable to handle kernel paging request
From: Vegard Nossum on 7 May 2008 02:50 Hi! On Wed, May 7, 2008 at 8:21 AM, Arjan van de Ven <arjan(a)infradead.org> wrote: > Subject: Add a WARN() macro; this is WARN_ON() + printk arguments > From: Arjan van de Ven <arjan(a)linux.intel.com> > > Add a WARN() macro that acts like WARN_ON(), with the added feature that > it takes a printk like argument that is printed as part of the warning > message. [...] > +#ifndef WARN > +#define WARN(condition, format...) ({ \ > + int __ret_warn_on = !!(condition); \ > + if (unlikely(__ret_warn_on)) \ > + __WARN_printf(format); \ > + unlikely(__ret_warn_on); \ > +}) > +#endif Is there a good reason why this is not a static inline function? If I've understood correctly, we want to turn as many macros as possible into functions, and I don't see an immediate reason why this one can't be one. > +void warn_slowpath(const char *file, int line, const char *fmt, ...) > +{ > + va_list args; > + > + > + char function[KSYM_SYMBOL_LEN]; > + unsigned long caller = (unsigned long) __builtin_return_address(0); If WARN() is made a static inline, you can call __builtin_return_address(0) there and pass it into here instead. This seems like a kind of low-level internal function anyway, because of the file/line info. OTOH, why can't you use __FUNCTION__ or __func__ to determine the caller (in WARN) rather than doing it here, at run-time? If it's to save space (or something like that), I think it should be documented? > + sprint_symbol(function, caller); > + > + printk(KERN_WARNING "------------[ cut here ]------------\n"); > + printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file, > + line, function); > + va_start(args, fmt); > + vprintk(fmt, args); > + va_end(args); > + > + print_modules(); > + dump_stack(); > + print_oops_end_marker(); > + add_taint(TAINT_WARN); > +} > +EXPORT_SYMBOL(warn_slowpath); > #endif Vegard -- "The animistic metaphor of the bug that maliciously sneaked in while the programmer was not looking is intellectually dishonest as it disguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Jiri Slaby on 7 May 2008 03:40
On 05/07/2008 08:21 AM, Arjan van de Ven wrote: > Subject: Add a WARN() macro; this is WARN_ON() + printk arguments [...] > --- a/include/asm-generic/bug.h > +++ b/include/asm-generic/bug.h > @@ -34,9 +34,13 @@ struct bug_entry { > #ifndef __WARN > #ifndef __ASSEMBLY__ > extern void warn_on_slowpath(const char *file, const int line); > +extern void warn_slowpath(const char *file, const int line, const char *fmt, ...); __attribute__((format(printf,3,4))) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |