Add support for Olimex SAM9-L9261 SBC
in [Kernel]
|
Prev: [PATCH] Staging:asus_oled: Fixed problem of style tabs in asus_oled.c
Next: Quick fix for the audio clocks on SAM9-L9261
From: Russell King - ARM Linux on 12 Mar 2010 05:10 On Fri, Mar 12, 2010 at 11:00:32AM +0100, Benjamin Valentin wrote: > diff -urpN -x CVS linux-2.6.34-rc1/arch/arm/configs/sam9_l9261_defconfig linux-2.6.34-rc1-olimex/arch/arm/configs/sam9_l9261_defconfig > --- linux-2.6.34-rc1/arch/arm/configs/sam9_l9261_defconfig 1970-01-01 02:00:00.000000000 +0200 > +++ linux-2.6.34-rc1-olimex/arch/arm/configs/sam9_l9261_defconfig 2008-10-28 06:08:46.000000000 +0200 > @@ -0,0 +1,1606 @@ Please think about your reviewers when you send patches - do you think it's reasonable to expect reviewers to scroll through 1600 lines before they get to something interesting to read? Always split defconfig patches into a separate patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Russell King - ARM Linux on 12 Mar 2010 05:20 On Fri, Mar 12, 2010 at 10:04:54AM +0000, Russell King - ARM Linux wrote: > On Fri, Mar 12, 2010 at 11:00:32AM +0100, Benjamin Valentin wrote: > > diff -urpN -x CVS linux-2.6.34-rc1/arch/arm/configs/sam9_l9261_defconfig linux-2.6.34-rc1-olimex/arch/arm/configs/sam9_l9261_defconfig > > --- linux-2.6.34-rc1/arch/arm/configs/sam9_l9261_defconfig 1970-01-01 02:00:00.000000000 +0200 > > +++ linux-2.6.34-rc1-olimex/arch/arm/configs/sam9_l9261_defconfig 2008-10-28 06:08:46.000000000 +0200 > > @@ -0,0 +1,1606 @@ > > Please think about your reviewers when you send patches - do you think > it's reasonable to expect reviewers to scroll through 1600 lines before > they get to something interesting to read? > > Always split defconfig patches into a separate patch. Oh, and please include a diffstat and signed-off-by lines as per Documentation/SubmittingPatches. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Nicolas Ferre on 12 Mar 2010 10:10
Hi, First and foremost, thank you for doing this job. It is indeed always a good idea to submit work to the community. Le 12/03/2010 11:00, Benjamin Valentin : [..] > diff -ru linux-2.6.34-rc1/drivers/video/atmel_lcdfb.c linux-2.6.34-rc1-olimex/drivers/video/atmel_lcdfb.c > --- linux-2.6.34-rc1/drivers/video/atmel_lcdfb.c 2010-02-24 19:52:17.000000000 +0100 > +++ linux-2.6.34-rc1-olimex/drivers/video/atmel_lcdfb.c 2010-02-25 16:11:58.665578876 +0100 In a separate patch please. You will also have to sent it to linux-fbdev-devel mailing list. > @@ -21,6 +21,7 @@ > #include <mach/board.h> > #include <mach/cpu.h> > #include <mach/gpio.h> > +#include <asm/mach-types.h> > > #include <video/atmel_lcdc.h> > > @@ -548,6 +549,10 @@ > if (!(info->var.sync & FB_SYNC_VERT_HIGH_ACT)) > value |= ATMEL_LCDC_INVFRAME_INVERTED; > > + if (machine_is_sam9_l9261()) { > + value |= ATMEL_LCDC_INVCLK_INVERTED; > + } > + Anyway, I think the driver is not the place to add this configuration. You will have to configure it in the board file: default_lcdcon2 field of the atmel_lcdfb_info structure. Check the arch/avr32/boards/atngw100/mrmr.c file as an example. > switch (info->var.bits_per_pixel) { > case 1: value |= ATMEL_LCDC_PIXELSIZE_1; break; > case 2: value |= ATMEL_LCDC_PIXELSIZE_2; break; > Bye, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |