Prev: [PATCH] Remove empty comment.
Next: linux-next: build warning after merge of the cifs tree
From: Linus Walleij on 31 Mar 2010 19:40
2010/3/31 Lemetayer Jean Marie <jeanmarie.lemetayer(a)altran.com>:

> +#ifdef CONFIG_VENDOR_TOOL_COMPATIBILITY
> +static struct nand_ecclayout nomadik_ecc_layout = {
> +������ .eccbytes = 3 * 4,
> +������ .eccpos = {
> +������ ������� 0x28, 0x29, 0x2A,
> +������ ������� 0x2B, 0x2C, 0x2D,
> +������ ������� 0x2E, 0x2F, 0x30,
> +������ ������� 0x31, 0x32, 0x33},
> +������ .oobfree = {{0x02, 0x26}, {0x34, 0x0C} },
> +};
> +#else
> �static struct nand_ecclayout nomadik_ecc_layout = {
> ������� .eccbytes = 3 * 4,
> ������� .eccpos = { /* each subpage has 16 bytes: pos 2,3,4 hosts ECC */
> @@ -54,6 +65,7 @@ static struct nand_ecclayout nomadik_ecc_layout = {
> ������� /* let's keep bytes 5,6,7 for us, just in case we change ECC algo */
> ������� .oobfree = { {0x08, 0x08}, {0x18, 0x08}, {0x28, 0x08}, {0x38, 0x08}
> },
> �};
> +#endif

Acked-by: Linus Walleij <linus.walleij(a)stericsson.com>

I don't think any of this layout belongs in the driver itself frankly speaking,
I am facing the need to use this in U300 and we use yet *another*
ECC layout with the FSMC, so we have to add yet another #ifdef.
However I can fix that up with a patch on top of this one after it's
queued.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Linus Walleij on 12 Apr 2010 20:30
2010/4/12 Jean-Michel Hautbois <jhautbois(a)gmail.com>:

> What king of modification would you do ?

Instead of coding the ECC layout into the driver I would move it to the
machine config in arch/arm/mach-* and pass it in as platform data
to the driver.

> Do you think it shall be queued before your submission ?

I will fix it for all users the day I have time, please queue this
as it is now.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH] Remove empty comment.
Next: linux-next: build warning after merge of the cifs tree