CAPI: Major rework, tons of bug fixes
in [Kernel]
|
Prev: [net-2.6 PATCH] MAINTAINERS: Add Intel igbvf maintainer
Next: x86, mce: Rename cpu_specific_poll to mce_cpu_specific_poll
From: David Miller on 23 Jan 2010 04:20 From: Jan Kiszka <jan.kiszka(a)web.de> Date: Sat, 23 Jan 2010 00:03:26 +0100 > First of all sorry if I'm breaking the correct flow of ISDN patches, but > I'm under the impression that things currently get merged directly via > Dave, right? > > This series can also be pulled from > > git://git.kiszka.org/linux-2.6.git capi This doesn't pull cleanly into net-next-2.6 which is where I would be adding it. There were a bunch of changes to the procfs code here and it conflicts with your changes. Please do a merge and sort things out, and then send another pull request. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Alan Cox on 8 Feb 2010 16:40 > o reworked locking of the NCCI TTY using latest and greatest tty_port > features and kref, hopefully in the right way Looks sane to me Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Karsten Keil on 9 Feb 2010 08:00 On Montag, 8. Februar 2010 21:12:04 Jan Kiszka wrote: > Here is the second take of my CAPI rework. I tried to address all > feedback on v1, so this one comes with the following changes: > > o rebased over net-next > o reworked locking of the NCCI TTY using latest and greatest tty_port > features and kref, hopefully in the right way > o more fine-grained patch steps for the tricky TTY rework > o dynamic major for NCCI TTYs, ie. CAPI no longer claims 191 > o dynamic TTY minor registrations, completely obsoleting capifs > o schedule capifs for removal > o some small additional cleanups > > I kept my capifs fixes though this thing should die in the future. The > work is done, and people may still use it due to their distro > configuration (and the hard-wired loading by capiinit - needs fixing). > > You can pull this series from > > git://git.kiszka.org/linux-2.6.git capi > Thank you for that effort, it looks very good for me. I will acknowlegde them, after a few tests. > Jan > > Jan Kiszka (41): > CAPI: Fix leaks in capifs_new_ncci > CAPI: Sanitize capifs API > CAPI: Eliminate capifs_root variable > CAPI: Pin capifs instead of mounting it > CAPI: Reduce chattiness during module loading/removal > CAPI: Call a controller 'controller', not 'card' > CAPI: Convert capi drivers rwlock into mutex > CAPI: Rework capi_ctr_ready/down > CAPI: Rework controller state notifier > CAPI: Rework locking of controller data structures > CAPI: Rework application locking > CAPI: Reduce #ifdef mess around CONFIG_ISDN_CAPI_MIDDLEWARE > CAPI: Convert capidev_list_lock into a mutex > CAPI: Clean up capi_open/release > CAPI: Rework locking of capidev members > CAPI: Use non-atomic allocation during NCCI setup > CAPI: Fix racy capi_read > CAPI: Switch NCCI list to standard doubly linked list > CAPI: Switch capiminor list to array > CAPI: Clean up capinc_tty_init/exit > CAPI: Dynamically register minor devices > CAPI: Use dynamic major for NCCI TTYs by default > CAPI: Use kref on capiminor > CAPI: Establish install/cleanup handlers for capiminor TTYs > CAPI: Use tty_port to keep track of capiminor's tty > CAPI: Drop remaining NULL checks on tty->driver_data > CAPI: Issue synchronous hangup on capincci_free_minor > CAPI: Drop obsolete nccip from capiminor struct > CAPI: Clean up capiminors_lock > CAPI: Drop atomic ttyopencount > CAPI: Drop handle_minor_recv from capinc_tty_write > CAPI: Rework capiminor RX handler > CAPI: Rename datahandle_queue -> ackqueue_entry > CAPI: Use atomics for capiminor's datahandle and msgid > CAPI: Drop capiminor's unused inbytes counter > CAPI: Fix locking around capiminor's output queue and drop > workaround_lock > CAPI: Clean up capiminor_*_ack > CAPI: Drop return value of handle_minor_send > CAPI: Drop special controller lookup from capi20_put_message > CAPI: Schedule capifs for removal > CAPI: Remove experimental tag from middleware feature > > Documentation/feature-removal-schedule.txt | 10 + > drivers/isdn/capi/Kconfig | 16 +- > drivers/isdn/capi/capi.c | 1108 > ++++++++++++++-------------- drivers/isdn/capi/capidrv.c | > 48 +- > drivers/isdn/capi/capifs.c | 126 ++-- > drivers/isdn/capi/capifs.h | 21 +- > drivers/isdn/capi/kcapi.c | 805 +++++++++++--------- > drivers/isdn/capi/kcapi.h | 13 +- > drivers/isdn/capi/kcapi_proc.c | 41 +- > include/linux/isdn/capilli.h | 5 +- > include/linux/kernelcapi.h | 17 +- > 11 files changed, 1151 insertions(+), 1059 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Tilman Schmidt on 10 Feb 2010 10:10 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2010-02-08 21:12 schrieb Jan Kiszka: > Here is the second take of my CAPI rework. I tried to address all > feedback on v1 [...] > I kept my capifs fixes though this thing should die in the future. The > work is done, and people may still use it due to their distro > configuration (and the hard-wired loading by capiinit - needs fixing). Great work. Many thanks for going through that effort! T. - -- Tilman Schmidt E-Mail: tilman(a)imap.cc Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Unge�ffnet mindestens haltbar bis: (siehe R�ckseite) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAktyy6YACgkQQ3+did9BuFvj7QCeO+qncLR2yGECEadwnWcVDo8Q piEAnj6ZzuZ4z68SmzI20YVV6AQN9LE9 =m+sN -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: David Miller on 15 Feb 2010 23:10
From: Karsten Keil <isdn(a)linux-pingi.de> Date: Tue, 9 Feb 2010 13:54:23 +0100 > Thank you for that effort, it looks very good for me. > > I will acknowlegde them, after a few tests. It's been more than a week later, will you be able to ever find time to do this "ACK"? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |