Prev: [PATCH 5/7] btrfs: fix bad exception handling of __btrfs_start_workers()
Next: kbuild: allow assignment to {A,C,LD}FLAGS_MODULE on the command line
From: Jiri Slaby on 29 Jul 2010 05:20
On 07/29/2010 11:09 AM, Jiri Slaby wrote:
> Currently ntty_install omits to increment tty count and we get the
> following warnings:
> Warning: dev (noz2) tty->count(0) != #fd's(1) in tty_open
>
> So to fix that, add one tty->count++ there.
>
> Signed-off-by: Jiri Slaby <jslaby(a)suse.cz>
> Cc: Alan Cox <alan(a)linux.intel.com>

BTW introduced in 266794eb7 (nozomi: Add tty_port usage) which is in
..34. So may be a stable material too...

> ---
> drivers/char/nozomi.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/char/nozomi.c b/drivers/char/nozomi.c
> index d578449..7f9b858 100644
> --- a/drivers/char/nozomi.c
> +++ b/drivers/char/nozomi.c
> @@ -1611,6 +1611,7 @@ static int ntty_install(struct tty_driver *driver, struct tty_struct *tty)
> ret = tty_init_termios(tty);
> if (ret == 0) {
> tty_driver_kref_get(driver);
> + tty->count++;
> driver->ttys[tty->index] = tty;
> }
> return ret;

thanks,
--
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 5/7] btrfs: fix bad exception handling of __btrfs_start_workers()
Next: kbuild: allow assignment to {A,C,LD}FLAGS_MODULE on the command line