CommitFest: how does handoff work for non-committer reviewers?
in [PgSql]
|
Prev: No answers on CommitFest procedures?
Next: CommitFest: how does handoff work for non-committerreviewers?
From: Josh Berkus on 9 Jul 2008 13:59 Folks, This commitfest we have a number of non-committer reviewers doing reviewing. When they're done with their review, how do they "handoff" to a committer for final check and commit? --Josh -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Josh Berkus on 9 Jul 2008 14:50 Neil, > One approach would be to assign a committer to each patch, in addition > to a reviewer (the committer and the reviewer might be the same, of > course). Once the reviewer has signed off on the patch, the committer > can do the final check over and commit. Well, one thing I think we want to do by having non-committer reviewers, is to not involve a committer at all if the patch is going to be sent back. So one thing I was thinking of is: 1) change status to "ready for committer" 2) post message to -hackers detailing the review and calling for a committer to check the patch 3) a committer picks it up -- --Josh Josh Berkus PostgreSQL @ Sun San Francisco -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 9 Jul 2008 15:14 Josh Berkus <josh(a)agliodbs.com> writes: > Well, one thing I think we want to do by having non-committer reviewers, is > to not involve a committer at all if the patch is going to be sent back. > So one thing I was thinking of is: > 1) change status to "ready for committer" > 2) post message to -hackers detailing the review and calling for a > committer to check the patch > 3) a committer picks it up Well, the key point there is just the sign-off in the review message. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 10 Jul 2008 15:07
Josh Berkus <josh(a)agliodbs.com> writes: > Tom Lane wrote: >> Josh Berkus <josh(a)agliodbs.com> writes: >>> 1) change status to "ready for committer" >>> 2) post message to -hackers detailing the review and calling for a >>> committer to check the patch >>> 3) a committer picks it up >> >> Well, the key point there is just the sign-off in the review message. > On the wiki, or on -hackers? On -hackers. All the substantive stuff should be in the mail archives; the wiki page is only a current-status display. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |