CommitFest rules
in [PgSql]
|
Prev: Switching between terminals
Next: Truncated queries when select * from pg_stat_activity - wishlist/ feature request
From: "Alex Hunsaker" on 3 Jul 2008 15:34 On Thu, Jul 3, 2008 at 12:44 PM, Dave Page <dpage(a)pgadmin.org> wrote: > it concerns me that despite it being day 3 of the July commit fest, > people are still being advised to add new items to the wiki page. > > To make the idea work, we need to stick to the rules we defined when > we came up with the concept - specifically, no new patches once the > fest begins! > > So please - new patches to the September page! > > Regards, Dave The one I advised be added (the Auto Explain patch) was posted on Mar 29, 2008 (http://archives.postgresql.org/pgsql-hackers/2008-03/msg01214.php), re-posted the Jun 30th and then an updated patch today... It only being the 3rd i figured it still meet the criteria. If thats not the case, I apologize. -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: "Dave Page" on 3 Jul 2008 15:45 On Thu, Jul 3, 2008 at 8:34 PM, Alex Hunsaker <badalex(a)gmail.com> wrote: > The one I advised be added (the Auto Explain patch) was posted on Mar > 29, 2008 (http://archives.postgresql.org/pgsql-hackers/2008-03/msg01214.php), > re-posted the Jun 30th and then an updated patch today... It only > being the 3rd i figured it still meet the criteria. If thats not the > case, I apologize. You'll note I didn't actually mention any specific patches. The CommitFests are designed to be short and quick to complete. We need *all* patches to be listed (not just posted to a list sometime in the past couple of months) before it starts, otherwise organisation of reviewers and completion of the Fest becomes chaotic for all and a nightmare task for the CommitFest manager. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: "Merlin Moncure" on 3 Jul 2008 16:45 On Thu, Jul 3, 2008 at 3:45 PM, Dave Page <dpage(a)pgadmin.org> wrote: > On Thu, Jul 3, 2008 at 8:34 PM, Alex Hunsaker <badalex(a)gmail.com> wrote: > >> The one I advised be added (the Auto Explain patch) was posted on Mar >> 29, 2008 (http://archives.postgresql.org/pgsql-hackers/2008-03/msg01214.php), >> re-posted the Jun 30th and then an updated patch today... It only >> being the 3rd i figured it still meet the criteria. If thats not the >> case, I apologize. > > You'll note I didn't actually mention any specific patches. > > The CommitFests are designed to be short and quick to complete. We > need *all* patches to be listed (not just posted to a list sometime in > the past couple of months) before it starts, otherwise organisation of > reviewers and completion of the Fest becomes chaotic for all and a > nightmare task for the CommitFest manager. Are you suggesting that omission of a patch on the 'fest' page means that you are bumped from the fest? Note that Tom asked on July 1 if there were any missing entries that hadn't been plucked out of the lists (there were). If that's the case, that would suggest that it is the patch author's responsibility to to update the fest entry (or at least, make sure it was updated). That may already be the case -- i'm not sure -- and I'm not saying that's wrong, but if you are going to adopt a strict policy (which btw I have no problem with) it's probably better to remind stragglers to get with the program a week or so the fest begins, especially on the last fest of the release cycle. merlin -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: Tom Lane on 3 Jul 2008 17:37 "Merlin Moncure" <mmoncure(a)gmail.com> writes: > Are you suggesting that omission of a patch on the 'fest' page means > that you are bumped from the fest? No, if you had submitted the patch on time then the correct next step is to get it added to the fest page; I don't think that should be controversial. But the reviewers aren't gonna review it if it's not listed on that page... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
From: "Dave Page" on 3 Jul 2008 18:16
On Thu, Jul 3, 2008 at 10:37 PM, Tom Lane <tgl(a)sss.pgh.pa.us> wrote: > "Merlin Moncure" <mmoncure(a)gmail.com> writes: >> Are you suggesting that omission of a patch on the 'fest' page means >> that you are bumped from the fest? > > No, if you had submitted the patch on time then the correct next step > is to get it added to the fest page; I don't think that should be > controversial. But the reviewers aren't gonna review it if it's not > listed on that page... Right, but the author should take some responsibility for ensuring the patch is listed on time. What we don't want is forgotten patches getting added at the last minute, right as the CommitFest manager is wrapping things up having got 95% of the patches reviewed and the other 5% in progress. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers(a)postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers |