From: Joe Perches on
On Wed, 2010-08-11 at 09:18 -0400, Davidlohr Bueso wrote:
> memory allocation in drm_bufs.c is followed by initializing the memory with 0.
>
> Replace the use of kmalloc+memset with kzalloc.

Perhaps kzalloc's with a multiply could/should also be converted
to kcalloc.

> + entry->buflist = kzalloc(count * sizeof(*entry->buflist), GFP_KERNEL);

entry->buflist = kcalloc(count, sizeof(*entry->buflist), GFP_KERNEL);

etc.

> + entry->buflist = kzalloc(count * sizeof(*entry->buflist), GFP_KERNEL);
> + entry->seglist = kzalloc(count * sizeof(*entry->seglist), GFP_KERNEL);
> + entry->buflist = kzalloc(count * sizeof(*entry->buflist),
> + entry->buflist = kzalloc(count * sizeof(*entry->buflist),


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Davidlohr Bueso on
On Wed, 2010-08-11 at 07:35 -0700, Joe Perches wrote:
> On Wed, 2010-08-11 at 09:18 -0400, Davidlohr Bueso wrote:
> > memory allocation in drm_bufs.c is followed by initializing the memory with 0.
> >
> > Replace the use of kmalloc+memset with kzalloc.
>
> Perhaps kzalloc's with a multiply could/should also be converted
> to kcalloc.
>
> > + entry->buflist = kzalloc(count * sizeof(*entry->buflist), GFP_KERNEL);
>
> entry->buflist = kcalloc(count, sizeof(*entry->buflist), GFP_KERNEL);
>
> etc.
>
> > + entry->buflist = kzalloc(count * sizeof(*entry->buflist), GFP_KERNEL);
> > + entry->seglist = kzalloc(count * sizeof(*entry->seglist), GFP_KERNEL);
> > + entry->buflist = kzalloc(count * sizeof(*entry->buflist),
> > + entry->buflist = kzalloc(count * sizeof(*entry->buflist),
>

Doable, but don't see much difference. David, what do you think?

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Kristian Høgsberg on
On Wed, Aug 11, 2010 at 3:58 PM, Davidlohr Bueso <dave(a)gnu.org> wrote:
> On Wed, 2010-08-11 at 07:35 -0700, Joe Perches wrote:
>> On Wed, 2010-08-11 at 09:18 -0400, Davidlohr Bueso wrote:
>> > memory allocation in drm_bufs.c is followed by initializing the memory with 0.
>> >
>> > Replace the use of kmalloc+memset with kzalloc.
>>
>> Perhaps kzalloc's with a multiply could/should also be converted
>> to kcalloc.
>>
>> > +   entry->buflist = kzalloc(count * sizeof(*entry->buflist), GFP_KERNEL);
>>
>>       entry->buflist = kcalloc(count, sizeof(*entry->buflist), GFP_KERNEL);
>>
>> etc.
>>
>> > +   entry->buflist = kzalloc(count * sizeof(*entry->buflist), GFP_KERNEL);
>> > +   entry->seglist = kzalloc(count * sizeof(*entry->seglist), GFP_KERNEL);
>> > +   entry->buflist = kzalloc(count * sizeof(*entry->buflist),
>> > +   entry->buflist = kzalloc(count * sizeof(*entry->buflist),
>>
>
> Doable, but don't see much difference. David, what do you think?

kcalloc does an integer overflow check, plus it's nice to be explicit
about allocating a number of elements of a certain size in the API.

Kristian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/