Prev: x86: Do not try to disable hpet if it hasn't been initialized before
Next: kobj: Fix memory leak on error path of kset_create_and_add
From: Greg KH on 22 Jul 2010 19:50
On Thu, Jul 22, 2010 at 03:09:01PM -0700, Patrick Pannuto wrote:
> In both of the 'goto out' cases, priv has already
> been allocated and assigned to bus->p. We reset
> bus->p to NULL, but neglect to free bus->p
>
> Signed-off-by: Patrick Pannuto <ppannuto(a)codeaurora.org>
> ---
> drivers/base/bus.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/base/bus.c b/drivers/base/bus.c
> index 12eec3f..eb1b7fa 100644
> --- a/drivers/base/bus.c
> +++ b/drivers/base/bus.c
> @@ -945,8 +945,8 @@ bus_devices_fail:
> bus_remove_file(bus, &bus_attr_uevent);
> bus_uevent_fail:
> kset_unregister(&bus->p->subsys);
> - kfree(bus->p);
> out:
> + kfree(bus->p);

This fix is already in my tree.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: x86: Do not try to disable hpet if it hasn't been initialized before
Next: kobj: Fix memory leak on error path of kset_create_and_add