EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6]
in [Kernel]
|
Prev: EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6]
Next: media: Add timberdale video-in driver
From: Sedat Dilek on 25 Apr 2010 11:20 [ Please CC - I am not subscribed to LKML ] [QUOTE] On 25.04.2010 16:26, Jongman Heo wrote: > I also hit this bug today. I also hit similar bug, maybe it is the same. > Doing git bisect, first bad commit was > > commit fda48a0d7a8412cedacda46a9c0bf8ef9cd13559 > tcp: bind() fix when many ports are bound > > Reverting above commit fixes the problem. How to do it? Would you please publish a reverting patch? Regards, Piotr Hosowicz [/QUOTE] Hi, did forget to mention 2.6.34-rc5-git5 was OK. Revering this commit did not help: commit f4f914b58019f0e50d521bbbadfaee260d766f95 net: ipv6 bind to device issue After looking into net-2.6 GIT repository, "tcp: bind() fix when many ports are bound" could cause indeed the problems here, too. Building now.... Regards, - Sedat - P.S.: Attached 0001-Revert-tcp-bind-fix-when-many-ports-are-bound.patch
From: Piotr Hosowicz on 25 Apr 2010 11:30 On 25.04.2010 17:11, Sedat Dilek wrote: > [ Please CC - I am not subscribed to LKML ] > > [QUOTE] > > On 25.04.2010 16:26, Jongman Heo wrote: > >> I also hit this bug today. > > I also hit similar bug, maybe it is the same. > >> Doing git bisect, first bad commit was >> >> commit fda48a0d7a8412cedacda46a9c0bf8ef9cd13559 >> tcp: bind() fix when many ports are bound >> >> Reverting above commit fixes the problem. > > How to do it? Would you please publish a reverting patch? > > Regards, > > Piotr Hosowicz > > [/QUOTE] > > Hi, > > did forget to mention 2.6.34-rc5-git5 was OK. > > Revering this commit did not help: > > commit f4f914b58019f0e50d521bbbadfaee260d766f95 > net: ipv6 bind to device issue > > After looking into net-2.6 GIT repository, "tcp: bind() fix when many > ports are bound" could cause indeed the problems here, too. > Building now.... > > Regards, > - Sedat - > > P.S.: Attached 0001-Revert-tcp-bind-fix-when-many-ports-are-bound.patch Thanks a lot. Applied and building now. Regards, Piotr Hosowicz -- Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach: - W kt�rym kraju znajduje si� Mount Everest? - Hm, to nie Szkocja, prawda? NP: Mark Knopfler - Cleaning My Gun NB: 2.6.34-rc5-git5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Sedat Dilek on 25 Apr 2010 12:40 [ CCing netdev ML ] Confirmed: The revert-patch [1] fixes the problem here. See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. Feel free to add a... Tested-by: Sedat Dilek <sedat.dilek(a)gmail.com> - Sedat - [1] https://patchwork.kernel.org/patch/94959/ [2] https://bugzilla.kernel.org/show_bug.cgi?id=15847 2010/4/25 Piotr Hosowicz <piotr(a)hosowicz.com>: > On 25.04.2010 17:11, Sedat Dilek wrote: >> >> [ Please CC - I am not subscribed to LKML ] >> >> [QUOTE] >> >> On 25.04.2010 16:26, Jongman Heo wrote: >> >>> I also hit this bug today. >> >> I also hit similar bug, maybe it is the same. >> >>> Doing git bisect, first bad commit was >>> >>> commit fda48a0d7a8412cedacda46a9c0bf8ef9cd13559 >>> tcp: bind() fix when many ports are bound >>> >>> Reverting above commit fixes the problem. >> >> How to do it? Would you please publish a reverting patch? >> >> Regards, >> >> Piotr Hosowicz >> >> [/QUOTE] >> >> Hi, >> >> did forget to mention 2.6.34-rc5-git5 was OK. >> >> Revering this commit did not help: >> >> commit f4f914b58019f0e50d521bbbadfaee260d766f95 >> net: ipv6 bind to device issue >> >> After looking into net-2.6 GIT repository, "tcp: bind() fix when many >> ports are bound" could cause indeed the problems here, too. >> Building now.... >> >> Regards, >> - Sedat - >> >> P.S.: Attached 0001-Revert-tcp-bind-fix-when-many-ports-are-bound.patch > > Thanks a lot. Applied and building now. > > Regards, > > Piotr Hosowicz > > -- > Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach: > - W którym kraju znajduje się Mount Everest? > - Hm, to nie Szkocja, prawda? > NP: Mark Knopfler - Cleaning My Gun > NB: 2.6.34-rc5-git5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Piotr Hosowicz on 25 Apr 2010 12:40 On 25.04.2010 18:31, Sedat Dilek wrote: > [ CCing netdev ML ] > > Confirmed: The revert-patch [1] fixes the problem here. I confirm, I've built a git6 kernel and it works fine. > See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. > > Feel free to add a... Tested-by: Sedat Dilek<sedat.dilek(a)gmail.com> I added created and tested phrase in my archive. ;-) Thank you a lot. I hope there will be no this error in git7. Regards, Piotr Hosowicz > - Sedat - > > [1] https://patchwork.kernel.org/patch/94959/ > [2] https://bugzilla.kernel.org/show_bug.cgi?id=15847 > > 2010/4/25 Piotr Hosowicz<piotr(a)hosowicz.com>: >> On 25.04.2010 17:11, Sedat Dilek wrote: >>> >>> [ Please CC - I am not subscribed to LKML ] >>> >>> [QUOTE] >>> >>> On 25.04.2010 16:26, Jongman Heo wrote: >>> >>>> I also hit this bug today. >>> >>> I also hit similar bug, maybe it is the same. >>> >>>> Doing git bisect, first bad commit was >>>> >>>> commit fda48a0d7a8412cedacda46a9c0bf8ef9cd13559 >>>> tcp: bind() fix when many ports are bound >>>> >>>> Reverting above commit fixes the problem. >>> >>> How to do it? Would you please publish a reverting patch? >>> >>> Regards, >>> >>> Piotr Hosowicz >>> >>> [/QUOTE] >>> >>> Hi, >>> >>> did forget to mention 2.6.34-rc5-git5 was OK. >>> >>> Revering this commit did not help: >>> >>> commit f4f914b58019f0e50d521bbbadfaee260d766f95 >>> net: ipv6 bind to device issue >>> >>> After looking into net-2.6 GIT repository, "tcp: bind() fix when many >>> ports are bound" could cause indeed the problems here, too. >>> Building now.... >>> >>> Regards, >>> - Sedat - >>> >>> P.S.: Attached 0001-Revert-tcp-bind-fix-when-many-ports-are-bound.patch >> >> Thanks a lot. Applied and building now. >> >> Regards, >> >> Piotr Hosowicz >> >> -- >> Z cyklu "Uroki demokracji", czyli pytania i odpowiedzi w teledurniejach: >> - W kt�rym kraju znajduje si� Mount Everest? >> - Hm, to nie Szkocja, prawda? >> NP: Mark Knopfler - Cleaning My Gun >> NB: 2.6.34-rc5-git5 >> > -- Grupa marze� w eliminacjach M� : Zimbabwe, Alaska, Grenlandia, Antarktyda i Zair. NP: Chickenfoot - Oh Yeah NB: 2.6.34-rc5-git6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Sedat Dilek on 25 Apr 2010 13:00 Rebuild ipv6 kernel-modules by: $ make M=net/ipv6 ....and copied net/ipv6/*.ko and net/ipv6/netfilter/*.ko files manually to the right place. Applied your patch (seen on netdev ML) already and booted into new kernel. Works, thanks. Tested-by: Sedat Dilek <sedat.dilek(a)gmail.com> - Sedat - On Sun, Apr 25, 2010 at 6:39 PM, Eric Dumazet <eric.dumazet(a)gmail.com> wrote: > Le dimanche 25 avril 2010 à 18:36 +0200, Piotr Hosowicz a écrit : >> On 25.04.2010 18:31, Sedat Dilek wrote: >> > [ CCing netdev ML ] >> > >> > Confirmed: The revert-patch [1] fixes the problem here. >> >> I confirm, I've built a git6 kernel and it works fine. >> >> > See also "Bug 15847 -  crash in inet6_csk_bind_conflict" [2]. >> > >> > Feel free to add a... Tested-by: Sedat Dilek<sedat.dilek(a)gmail.com> >> >> I added created and tested phrase in my archive. ;-) Thank you a lot. I >> hope there will be no this error in git7. >> > > Did you test the proposed fix ? > > > [PATCH] ipv6: Fix inet6_csk_bind_conflict() > > Commit fda48a0d7a84 (tcp: bind() fix when many ports are bound) > introduced a bug on IPV6 part. > We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but > ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is > IPV6. > > Reported-by: Michael S. Tsirkin <mst(a)redhat.com> > Signed-off-by: Eric Dumazet <eric.dumazet(a)gmail.com> > --- > diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c > index b4b7d40..3a4d92b 100644 > --- a/net/ipv6/inet6_connection_sock.c > +++ b/net/ipv6/inet6_connection_sock.c > @@ -48,7 +48,7 @@ int inet6_csk_bind_conflict(const struct sock *sk, >               ipv6_rcv_saddr_equal(sk, sk2)) >                 break; >             else if (sk->sk_reuse && sk2->sk_reuse && > -                !ipv6_addr_any(inet6_rcv_saddr(sk2)) && > +                !ipv6_addr_any(inet6_rcv_saddr(sk)) && >                 ipv6_rcv_saddr_equal(sk, sk2)) >                 break; >         } > > >
|
Next
|
Last
Pages: 1 2 Prev: EIP: is at inet6_csk_bind_conflict + 06xe/0xb7 [ipv6] Next: media: Add timberdale video-in driver |