From: Dominik Brodowski on
On Mon, Apr 26, 2010 at 05:41:56PM -0400, Dave Jones wrote:
> On Sun, Apr 18, 2010 at 11:59:49AM -0700, Arjan van de Ven wrote:
> > There have been various reports of the ondemand governor causing some
> > serious performance issues, one of the latest ones from Andrew.
> > There are several fundamental issues with ondemand (being worked on),
> > but the report from Andrew can be fixed relatively easily.
> >
> > The fundamental issue is that ondemand will go to a (too) low CPU
> > frequency for workloads that alternatingly disk and CPU bound...
>
> given the scheduler changes, these probably make more sense to go
> via one of Ingo's trees ?
> If everyone agrees, feel free to add my Signed-off-by:

What about the issue Pavel reported and Willy confirmed (regression
on older hardware)?

Best,
Dominik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Dave Jones on
On Sun, Apr 18, 2010 at 11:59:49AM -0700, Arjan van de Ven wrote:
> There have been various reports of the ondemand governor causing some
> serious performance issues, one of the latest ones from Andrew.
> There are several fundamental issues with ondemand (being worked on),
> but the report from Andrew can be fixed relatively easily.
>
> The fundamental issue is that ondemand will go to a (too) low CPU
> frequency for workloads that alternatingly disk and CPU bound...

given the scheduler changes, these probably make more sense to go
via one of Ingo's trees ?
If everyone agrees, feel free to add my Signed-off-by:

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Rik van Riel on
On 04/26/2010 05:45 PM, Dominik Brodowski wrote:

>> given the scheduler changes, these probably make more sense to go
>> via one of Ingo's trees ?
>> If everyone agrees, feel free to add my Signed-off-by:
>
> What about the issue Pavel reported and Willy confirmed (regression
> on older hardware)?

Having a /sys tunable makes sense, especially when running
on battery power. I guess that can be introduced as a patch
8/7 :)

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Dominik Brodowski on
On Mon, Apr 26, 2010 at 05:59:39PM -0400, Rik van Riel wrote:
> On 04/26/2010 05:45 PM, Dominik Brodowski wrote:
>
>>> given the scheduler changes, these probably make more sense to go
>>> via one of Ingo's trees ?
>>> If everyone agrees, feel free to add my Signed-off-by:
>>
>> What about the issue Pavel reported and Willy confirmed (regression
>> on older hardware)?
>
> Having a /sys tunable makes sense, especially when running
> on battery power. I guess that can be introduced as a patch
> 8/7 :)

.... only if combined with sane default values.

Best,
Dominik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Ingo Molnar on

* Arjan van de Ven <arjan(a)infradead.org> wrote:

> [Version 2 includes the acks/etc. Andrew: no changes from the patches that
> are in -mm]
>
> There have been various reports of the ondemand governor causing some
> serious performance issues, one of the latest ones from Andrew. There are
> several fundamental issues with ondemand (being worked on), but the report
> from Andrew can be fixed relatively easily.
>
> The fundamental issue is that ondemand will go to a (too) low CPU frequency
> for workloads that alternatingly disk and CPU bound...

I've applied your series to sched/core and started testing it, thanks Arjan!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/