Fwd: Fwd: fs/exec.c core dumping on NFS mounted directory
in [Kernel]
|
Prev: Regression caused by commit cc56f7de7f00d188c7c4da1e9861581853b9e92f
Next: network driver dev/debugging (sis190/sis191)
From: Lei Sun on 25 Jun 2010 16:50 From: Lei Sun <leisun124(a)gmail.com> Date: Fri, Jun 25, 2010 at 1:39 PM Subject: Re: Fwd: fs/exec.c core dumping on NFS mounted directory To: Trond Myklebust <trond.myklebust(a)fys.uio.no> On Fri, Jun 25, 2010 at 1:01 PM, Trond Myklebust <trond.myklebust(a)fys.uio.no> wrote: > On Fri, 2010-06-25 at 12:32 -0700, Lei Sun wrote: >> � In 2.6.3x, I am logging in as a root and running app from NFS >> mounted directory. The app crashed with 0 bytes core file (I have set >> "ulimit -c unlimited", so it's not an issue). >> >> Proposed patch: >> >> --- exec.c 2010-05-19 17:33:16.000000000 -0700 >> +++ exec.c.new 2010-05-19 17:33:07.000000000 -0700 >> @@ -1859,7 +1859,7 @@ >> � � �* Dont allow local users get cute and trick others to coredump >> � � �* into their pre-created files: >> � � �*/ >> - if (inode->i_uid != current_fsuid()) >> + if (inode->i_bytes != 0 && inode->i_uid != current_fsuid()) >> � � � � goto close_fail; >> >> � � if (!file->f_op) >> > ... which would go ahead and reintroduce bugzilla entry 3043, but only > for those filesystems that set inode->i_bytes to zero: > � � � � � https://bugzilla.kernel.org/show_bug.cgi?id=3043 > > NACKed... > > Trond > > If existing core file size is 0, it will be replaced, otherwise it won't , is this a problem? �The 0 bytes core file is not useful anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |