Prev: [PATCH 0/5] blkdev: discard optimizations v2 RESEND
Next: [PATCH 4/5] powernow-k8: Fix frequency reporting
From: Benny Halevy on 25 Mar 2010 06:30
On Mar. 25, 2010, 12:12 +0200, Al Viro <viro(a)ZenIV.linux.org.uk> wrote:
> On Thu, Mar 25, 2010 at 11:39:38AM +0200, Boaz Harrosh wrote:
>
>> It makes no difference, fails just the same. Would an "strace" help?
>
> It might, especially if you ran it for identical repositories on local
> fs and on NFS; at least that way it would be possible to see where do
> they diverge...
> _______________________________________________
> pNFS mailing list
> pNFS(a)linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs

ext3 fs exported on the server
client mount -t nfs4 localhost:/ /mnt/localhost
$ strace git status
....
open(".git/objects/pack", O_RDONLY|O_NONBLOCK|O_DIRECTORY|0x80000) = -1 EISDIR (Is a directory)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Benny Halevy on 25 Mar 2010 06:40
On Mar. 25, 2010, 12:22 +0200, Benny Halevy <bhalevy(a)panasas.com> wrote:
> On Mar. 25, 2010, 12:12 +0200, Al Viro <viro(a)ZenIV.linux.org.uk> wrote:
>> On Thu, Mar 25, 2010 at 11:39:38AM +0200, Boaz Harrosh wrote:
>>
>>> It makes no difference, fails just the same. Would an "strace" help?
>> It might, especially if you ran it for identical repositories on local
>> fs and on NFS; at least that way it would be possible to see where do
>> they diverge...
>> _______________________________________________
>> pNFS mailing list
>> pNFS(a)linux-nfs.org
>> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>
> ext3 fs exported on the server
> client mount -t nfs4 localhost:/ /mnt/localhost
> $ strace git status
> ...
> open(".git/objects/pack", O_RDONLY|O_NONBLOCK|O_DIRECTORY|0x80000) = -1 EISDIR (Is a directory)

FWIW, This could be timing related as retrying with nfs debugging on
failed to reproduce the problem.

Benny

> _______________________________________________
> pNFS mailing list
> pNFS(a)linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Al Viro on 25 Mar 2010 06:50
On Thu, Mar 25, 2010 at 12:22:31PM +0200, Benny Halevy wrote:
> On Mar. 25, 2010, 12:12 +0200, Al Viro <viro(a)ZenIV.linux.org.uk> wrote:
> > On Thu, Mar 25, 2010 at 11:39:38AM +0200, Boaz Harrosh wrote:
> >
> >> It makes no difference, fails just the same. Would an "strace" help?
> >
> > It might, especially if you ran it for identical repositories on local
> > fs and on NFS; at least that way it would be possible to see where do
> > they diverge...
> > _______________________________________________
> > pNFS mailing list
> > pNFS(a)linux-nfs.org
> > http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>
> ext3 fs exported on the server
> client mount -t nfs4 localhost:/ /mnt/localhost
> $ strace git status
> ...
> open(".git/objects/pack", O_RDONLY|O_NONBLOCK|O_DIRECTORY|0x80000) = -1 EISDIR (Is a directory)

Interesting. It is a directory, indeed, but why the hell does that call
fail with -EISDIR?

Does that happen with nfsv3 or is that v4-only? I'm going to set up v4
server and client and see what happens, but that information could be
useful...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Al Viro on 25 Mar 2010 07:00
On Thu, Mar 25, 2010 at 10:12:31AM +0000, Al Viro wrote:
> On Thu, Mar 25, 2010 at 11:39:38AM +0200, Boaz Harrosh wrote:
>
> > It makes no difference, fails just the same. Would an "strace" help?
>
> It might, especially if you ran it for identical repositories on local
> fs and on NFS; at least that way it would be possible to see where do
> they diverge...

I wonder... What happens if you add
if (error == -EISDIR)
printk("blah: %s", pathname);
right after do_lookup() call in do_last()? That would separate -EISDIR
coming from NFS from the same thing coming from fs/namei.c...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Benny Halevy on 25 Mar 2010 07:00
On Mar. 25, 2010, 12:49 +0200, Al Viro <viro(a)ZenIV.linux.org.uk> wrote:
> On Thu, Mar 25, 2010 at 12:22:31PM +0200, Benny Halevy wrote:
>> On Mar. 25, 2010, 12:12 +0200, Al Viro <viro(a)ZenIV.linux.org.uk> wrote:
>>> On Thu, Mar 25, 2010 at 11:39:38AM +0200, Boaz Harrosh wrote:
>>>
>>>> It makes no difference, fails just the same. Would an "strace" help?
>>> It might, especially if you ran it for identical repositories on local
>>> fs and on NFS; at least that way it would be possible to see where do
>>> they diverge...
>>> _______________________________________________
>>> pNFS mailing list
>>> pNFS(a)linux-nfs.org
>>> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
>> ext3 fs exported on the server
>> client mount -t nfs4 localhost:/ /mnt/localhost
>> $ strace git status
>> ...
>> open(".git/objects/pack", O_RDONLY|O_NONBLOCK|O_DIRECTORY|0x80000) = -1 EISDIR (Is a directory)
>
> Interesting. It is a directory, indeed, but why the hell does that call
> fail with -EISDIR?
>
> Does that happen with nfsv3 or is that v4-only? I'm going to set up v4
> server and client and see what happens, but that information could be
> useful...

We've seen this with v4 only so far.

BTW I added this WARN_ON:
@@ -1656,8 +1659,10 @@ static struct file *do_last(struct nameidata *nd, struct path *path,
if (path->dentry->d_inode->i_op->follow_link)
return NULL;
error = -ENOTDIR;
- if (*want_dir && !path->dentry->d_inode->i_op->lookup)
+ if (*want_dir && !path->dentry->d_inode->i_op->lookup) {
+ WARN_ON(1);
goto exit_dput;
+ }
path_to_nameidata(path, nd);
audit_inode(pathname, nd->path.dentry);
goto ok;

but it is NOT tripping for this scenario.

(for some reason I saw it tripping when building the kernel over nfs
but it's benign)

Benny
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  |  Next  |  Last
Pages: 1 2 3 4 5 6 7
Prev: [PATCH 0/5] blkdev: discard optimizations v2 RESEND
Next: [PATCH 4/5] powernow-k8: Fix frequency reporting