HID: N-trig MTM Driver fix and cleanup patch 2
in [Kernel]
|
Prev: [BUGFIX][PATCH] fix sync_mm_rss in nommu (Was Re: sync_mm_rss() issues
Next: fs, binfmt_aout: Fix pointer warnings
From: Rafi Rubin on 8 Mar 2010 20:10 > - case HID_DG_CONTACTID: /* Not trustworthy, squelch for now */ I squelched contact id because they don't actually track fingers, rather contacts are reported spatially (seems to be from the bottom to top) making this value useless for tracking (after all the user space tools can count contacts since the start of the group). See the "Finger Tracking" section in Documentation/input/multi-touch-protocol.txt When tracking id is incorrect its better to just leave it out. > + case HID_DG_INVERT: /* value is always 0 */ > + case HID_DG_ERASER: /* value is always 0 */ > + case HID_DG_CONTACTID: /* value is useless */ > + case HID_DG_BARRELSWITCH: /* doubtful */ Stephane put these here erroneously. He was working with a firmware that didn't support the stylus at all when he made those observations. These events are useful and should not be squelched. > + case HID_DG_CONTACTCOUNT: See the rdesc for the device. "Digitizers.ContactCount ---> Sync.Report" As the last event sent by a mt group, that is already mapped to input_sync(). If you don't squelch it, you don't need to implicitly add the sync. > case HID_DG_HEIGHT: > hid_map_usage(hi, usage, bit, max, > EV_ABS, ABS_MT_TOUCH_MINOR); > - input_set_abs_params(hi->input, ABS_MT_ORIENTATION, > - 0, 1, 0, 0); Stephane added the orientation to height, I can't comment about the wisdom of pulling it. Rafi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Stéphane Chatty on 9 Mar 2010 10:50
Le 9 mars 10 � 02:07, Rafi Rubin a �crit : > >> case HID_DG_HEIGHT: >> hid_map_usage(hi, usage, bit, max, >> EV_ABS, ABS_MT_TOUCH_MINOR); >> - input_set_abs_params(hi->input, ABS_MT_ORIENTATION, >> - 0, 1, 0, 0); > > Stephane added the orientation to height, I can't comment about the > wisdom of pulling it. The MT kernel protocol says that width/height is reported through TouchMinor/TouchMajor/Orientation. Orientation needs to be added somewhere. Doing it when encountering width or height seemed a logical thing to do, but I would see no objection at doing it somewhere else with TouchMinor and TouchMajor. Cheers, St. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |