Prev: [RFC Patch 3/3] bonding: make bonding support netpoll
Next: [PATCH] x86: hpet: work around wrong number of timers in ID register
From: Jiri Kosina on 22 Mar 2010 04:50
On Thu, 18 Mar 2010, Stefan Achatz wrote:

> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -399,6 +399,9 @@
> #define USB_VENDOR_ID_PRODIGE 0x05af
> #define USB_DEVICE_ID_PRODIGE_CORDLESS 0x3062
>
> +#define USB_VENDOR_ID_ROCCAT 0x1e7d
> +#define USB_DEVICE_ID_ROCCAT_KONE 0x2ced
> +

Hi Stefan,

I guess you also need hid_blacklist[] entry for these device IDs, so that
generic HID driver doesn't grab the device before your driver gets to it,
right?

> +static struct hid_driver kone_driver = { .name = "kone",
> + .id_table = kone_devices, .probe = kone_probe,
> + .remove = kone_remove, .raw_event = kone_raw_event, };

Could you please put each filed that is being initialized on a separate
line?

Other than that, the patch looks quite fine to me.

Thanks,

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [RFC Patch 3/3] bonding: make bonding support netpoll
Next: [PATCH] x86: hpet: work around wrong number of timers in ID register