Prev: Bluetooth: Fix abuse of the preincrement operator
Next: [PATCH 2/2] Removing dead CONFIG_IOMMU_DEBUG
From: Xiao Guangrong on 3 Jul 2010 04:20


Marcelo Tosatti wrote:

>> +
>> + if (is_rsvd_bits_set(vcpu, gpte, PT_PAGE_TABLE_LEVEL))
>> + break;
>
> BTW, doesnt sync_page also lack reserved bit checking? (unrelated to
> this patch).
>

I think it's not since if EPT is enabled, no unsync page exist, the sync page
path can't be trigged. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Xiao Guangrong on 5 Jul 2010 21:00


Marcelo Tosatti wrote:
> On Sat, Jul 03, 2010 at 04:08:42PM +0800, Xiao Guangrong wrote:
>>
>> Marcelo Tosatti wrote:
>>
>>>> +
>>>> + if (is_rsvd_bits_set(vcpu, gpte, PT_PAGE_TABLE_LEVEL))
>>>> + break;
>>> BTW, doesnt sync_page also lack reserved bit checking? (unrelated to
>>> this patch).
>>>
>> I think it's not since if EPT is enabled, no unsync page exist, the sync page
>> path can't be trigged. :-)
>
> What i mean is, why the sync_page path does not require reserved bit
> checking? (EPT disabled).
>

Oh, i think we should check it, i'll post a patch to fix it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2 3
Prev: Bluetooth: Fix abuse of the preincrement operator
Next: [PATCH 2/2] Removing dead CONFIG_IOMMU_DEBUG