[PATCH 14/17] drivers/char/n_gsm.c: Add missing spin_unlock_irqrestore
From: Julia Lawall <julia(a)diku.dk> Add a spin_unlock_irqrestore missing on the error path. Converting the return to break leads to the spin_unlock_irqrestore at the end of the function. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression E1; @@ ... 26 May 2010 12:28
[PATCH 7/17] arch/arm/common: Add missing spin_unlock_irqrestore
From: Julia Lawall <julia(a)diku.dk> Add a spin_unlock_irqrestore missing on the error path. Although the lock is destroyed with the rest of the sachip structure in the function __sa1111_remove, it still seems useful to restore the interrupt state. The semantic match that finds this problem is as follows: (http... 26 May 2010 12:28
[PATCH 10/17] arch/ia64/kvm: Add missing spin_unlock
From: Julia Lawall <julia(a)diku.dk> Add a spin_unlock missing on the error path. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression E1; @@ * spin_lock(E1,...); <+... when != E1 if (...) { ... when != E1 * return ...; } ...+> ... 26 May 2010 12:28
[PATCH] do_generic_file_read: clear page errors when issuing a fresh read of the page
From: Jeff Moyer <jmoyer(a)redhat.com> I/O errors can happen due to temporary failures, like multipath errors or losing network contact with the iSCSI server. Because of that, the VM will retry readpage on the page. However, do_generic_file_read does not clear PG_error. This causes the system to be unable to ac... 26 May 2010 12:28
[PATCH 15/17] fs/ocfs2/dlm: Add missing spin_unlock
From: Julia Lawall <julia(a)diku.dk> Add a spin_unlock missing on the error path. Unlock as in the other code that leads to the leave label. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression E1; @@ * spin_lock(E1,...); <+... when != E1 i... 26 May 2010 12:28
[PATCH 5/17] drivers/media/video/pvrusb2: Add missing mutex_unlock
From: Julia Lawall <julia(a)diku.dk> Add a mutex_unlock missing on the error path. In the other functions in the same file the locks and unlocks of this mutex appear to be balanced, so it would seem that the same should hold in this case. The semantic match that finds this problem is as follows: (http://coccine... 26 May 2010 12:28
[PATCH 11/17] fs/xfs/quota: Add missing mutex_unlock
From: Julia Lawall <julia(a)diku.dk> Add a mutex_unlock missing on the error path. The use of this lock is balanced elsewhere in the file. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression E1; @@ * mutex_lock(E1,...); <+... when != E1 if... 2 Jun 2010 00:05
[PATCH 12/17] drivers/video/omap2/displays: Add missing mutex_unlock
From: Julia Lawall <julia(a)diku.dk> Add a mutex_unlock missing on the error paths. The use of the mutex is balanced elsewhere in the file. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression E1; @@ * mutex_lock(E1,...); <+... when != E1 i... 26 May 2010 12:28
do_generic_file_read: clear page errors when issuing a fresh read of the page
On Wed, 2010-05-26 at 11:49 -0400, Rik van Riel wrote: From: Jeff Moyer <jmoyer(a)redhat.com> I/O errors can happen due to temporary failures, like multipath errors or losing network contact with the iSCSI server. Because of that, the VM will retry readpage on the page. However, do_generic_file_rea... 26 May 2010 12:27
[PATCH 8/17] net/caif: Add missing spin_unlock
From: Julia Lawall <julia(a)diku.dk> Add a spin_unlock missing on the error path. The spin lock is used in a balanced way elsewhere in the file. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression E1; @@ * spin_lock(E1,...); <+... when != E1 ... 26 May 2010 12:27