MIPS: remove RELOC_HIDE on __pa_symbol
in [Kernel]
|
Prev: sparc: add pdt/of_pdt namespace to pdt code
Next: [RFC PATCH 1/2] debug_core: move all watch dog syncs to a single function
From: David Daney on 9 Aug 2010 01:20 On 08/08/2010 12:57 PM, Namhyung Kim wrote: > remove unneccessary use of RELOC_HIDE(). It does simple addition of ptr and > offset and in this case (offset 0) does practically nothing. It does NOT do > anything with linker relocation. > Maybe you could explain in more detail the problems you are having with the current definition of __pa_symbol(). I would be hesitant to change this bit of black magic unless there is a concrete problem you are trying to solve. David Daney > Signed-off-by: Namhyung Kim<namhyung(a)gmail.com> > --- > arch/mips/include/asm/page.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/mips/include/asm/page.h b/arch/mips/include/asm/page.h > index a16beaf..f7e2684 100644 > --- a/arch/mips/include/asm/page.h > +++ b/arch/mips/include/asm/page.h > @@ -150,7 +150,7 @@ typedef struct { unsigned long pgprot; } pgprot_t; > ((unsigned long)(x) - PAGE_OFFSET + PHYS_OFFSET) > #endif > #define __va(x) ((void *)((unsigned long)(x) + PAGE_OFFSET - PHYS_OFFSET)) > -#define __pa_symbol(x) __pa(RELOC_HIDE((unsigned long)(x), 0)) > +#define __pa_symbol(x) __pa(x) > > #define pfn_to_kaddr(pfn) __va((pfn)<< PAGE_SHIFT) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Ralf Baechle on 9 Aug 2010 08:30 On Sun, Aug 08, 2010 at 10:15:04PM -0700, David Daney wrote: > On 08/08/2010 12:57 PM, Namhyung Kim wrote: > >remove unneccessary use of RELOC_HIDE(). It does simple addition of ptr and > >offset and in this case (offset 0) does practically nothing. It does NOT do > >anything with linker relocation. > > > > Maybe you could explain in more detail the problems you are having > with the current definition of __pa_symbol(). I would be hesitant > to change this bit of black magic unless there is a concrete problem > you are trying to solve. RELOC_HIDE was originally added by 6007b903dfe5f1d13e0c711ac2894bdd4a61b1ad (lmo) rsp. 8431fd094d625b94d364fe393076ccef88e6ce18 (kernel.org). A discussion can be found in lkml posting a2ebde260608230500o3407b108hc03debb9da6e62c(a)mail.gmail.com> which is archived at http://lists.linuxcoding.com/kernel/2006-q3/msg17360.html I felt this was dubious by the time it was added and probably should go? Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
From: Namhyung Kim on 9 Aug 2010 23:10
2010-08-09 (월), 13:21 +0100, Ralf Baechle: > On Sun, Aug 08, 2010 at 10:15:04PM -0700, David Daney wrote: > > Maybe you could explain in more detail the problems you are having > > with the current definition of __pa_symbol(). I would be hesitant > > to change this bit of black magic unless there is a concrete problem > > you are trying to solve. > > RELOC_HIDE was originally added by 6007b903dfe5f1d13e0c711ac2894bdd4a61b1ad > (lmo) rsp. 8431fd094d625b94d364fe393076ccef88e6ce18 (kernel.org). A > discussion can be found in lkml posting > a2ebde260608230500o3407b108hc03debb9da6e62c(a)mail.gmail.com> which is > archived at > > http://lists.linuxcoding.com/kernel/2006-q3/msg17360.html > > I felt this was dubious by the time it was added and probably should go? > > Ralf Hi, I've sent basically same patch to x86 folks [1] and they said there is a possiblility of miscompilation on gcc 3. I am not sure the same goes here on mips but it might be safer to keep it. Sorry for the noise ;-( [1] http://lkml.org/lkml/2010/8/8/138 -- Regards, Namhyung Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |