Prev: PROBLEM: SIS7019 stops recording after 42 min
Next: [PATCH v3] alsa: ASoC: Add JZ4740 codec driver
From: Andrew Morton on 15 Jul 2010 17:20
On Thu, 15 Jul 2010 23:06:04 +0200
Lars-Peter Clausen <lars(a)metafoo.de> wrote:

> This patch adds support for the mmc controller on JZ4740 SoCs.
>
>
> ...
>
> + if (gpio_is_valid(host->pdata->gpio_power))
> + gpio_set_value(host->pdata->gpio_power,
> + !host->pdata->power_active_low);
>
> ...
>

Should this driver have a `depends on GPIOLIB' in Kconfig?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Lars-Peter Clausen on 15 Jul 2010 17:40
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Morton wrote:
> On Thu, 15 Jul 2010 23:06:04 +0200
> Lars-Peter Clausen <lars(a)metafoo.de> wrote:
>
>> This patch adds support for the mmc controller on JZ4740 SoCs.
>>
>>
>> ...
>>
>> + if (gpio_is_valid(host->pdata->gpio_power))
>> + gpio_set_value(host->pdata->gpio_power,
>> + !host->pdata->power_active_low);
>>
>> ...
>>
>
> Should this driver have a `depends on GPIOLIB' in Kconfig?
>

The driver depends on MACH_JZ4740 which selects ARCH_REQUIRE_GPIOLIB, so there
already is an implicit depends on GPIOLIB.

- - Lars
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEUEARECAAYFAkw/f60ACgkQBX4mSR26RiNexQCfUXt0cqiMqEf17k+z+q6XVwRO
ImEAmPKxeyX9ANVasUNL60f51GxKofg=
=3NrE
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
First  |  Prev  | 
Pages: 1 2 3
Prev: PROBLEM: SIS7019 stops recording after 42 min
Next: [PATCH v3] alsa: ASoC: Add JZ4740 codec driver