Prev: [PATCH v3] cpuidle: extend cpuidle and menu governor to handle dynamic states
Next: PCI: Do not run NVidia quirks related to MSI with MSI disabled
From: Sergei Shtylyov on 30 Jul 2010 12:10
Uwe Kleine-König wrote:

> This fixes the following warning by modpost:

> WARNING: vmlinux.o(.data+0x15018): Section mismatch in reference from the variable pxa2xx_flash_driver to the function .init.text:pxa2xx_flash_probe()
> The variable pxa2xx_flash_driver references
> the function __init pxa2xx_flash_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,

> I choosed to do this instead of using platform_driver_probe as the remove

s/choosed/chose/

> function uses __devexit.

Perhaps remove() method should have been fixed instead -- I doubt that
this is a hotplug device.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Uwe Kleine-König on 30 Jul 2010 15:00
On Fri, Jul 30, 2010 at 07:58:57PM +0400, Sergei Shtylyov wrote:
> Uwe Kleine-K�nig wrote:
>
>> This fixes the following warning by modpost:
>
>> WARNING: vmlinux.o(.data+0x15018): Section mismatch in reference from the variable pxa2xx_flash_driver to the function .init.text:pxa2xx_flash_probe()
>> The variable pxa2xx_flash_driver references
>> the function __init pxa2xx_flash_probe()
>> If the reference is valid then annotate the
>> variable with __init* or __refdata (see linux/init.h) or name the variable:
>> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>
>> I choosed to do this instead of using platform_driver_probe as the remove
>
> s/choosed/chose/
oh right, thanks.

>> function uses __devexit.
>
> Perhaps remove() method should have been fixed instead -- I doubt that
> this is a hotplug device.
Actually I don't care much.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K�nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH v3] cpuidle: extend cpuidle and menu governor to handle dynamic states
Next: PCI: Do not run NVidia quirks related to MSI with MSI disabled