From: Luke-Jr on
This doesn't even build, so I don't know how it was tested... Reverting the
offending commit (simple, but does require conflict resolution) at least lets
it compile, but I haven't tested whether it alone is enough to work in
practise yet... hoping Tomi might provide a real fix. Maybe even in time for
2.6.35 final? :)

https://bugzilla.kernel.org/show_bug.cgi?id=16144

CC drivers/video/omap/rfbi.o
drivers/video/omap/rfbi.c: In function 'rfbi_get_clocks':
drivers/video/omap/rfbi.c:86: error: 'dispc' undeclared (first use in this
function)
drivers/video/omap/rfbi.c:86: error: (Each undeclared identifier is reported
only once
drivers/video/omap/rfbi.c:86: error: for each function it appears in.)
make[1]: *** [drivers/video/omap/rfbi.o] Error 1
make: *** [drivers/video/omap/rfbi.o] Error 2

The 'dispc' referred to herein is and has always been defined in
drivers/video/omap/dispc.c as an anonymous struct.

Broken in...
commit f778a12dd33200513596a0d4d3ba4d5f09e79c09
Author: Tomi Valkeinen <tomi.valkeinen(a)nokia.com>
Date: Wed Dec 16 13:18:07 2009 +0200

OMAP: OMAPFB: fix clk_get for RFBI

omapfb platform device was still used to get clocks inside rfbi.c

Signed-off-by: Tomi Valkeinen <tomi.valkeinen(a)nokia.com>
Tested-by: Sergey Lapin <slapin(a)ossfans.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Luke-Jr on
On Monday 07 June 2010 02:47:34 am Tomi Valkeinen wrote:
> I don't have any device that uses RFBI so I can't test it, but how about
> this patch:

Unfortunately, I can't test it either since N8x0 has no mainline support for
video output, nor can until CBus is merged. :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/