Prev: [PATCH v2] fujitsu-laptop: remove unnecessary input_free_device calls
Next: [PATCH 1/2] block: introduce REQ_FLUSH flag
From: FUJITA Tomonori on 2 Jul 2010 03:40
scsi-ml builds flush requests via q->prepare_flush_fn(), however,
builds discard requests via q->prep_rq_fn.

Using two different mechnisms for the similar requests (building
commands in SCSI ULD) doesn't make sense.

Handing both via q->prep_rq_fn makes the code simpler.

We could kill q->prepare_flush_fn(). Except for ide, all the users
just mark flush requests. They can use REQ_FLUSH flag instead. Ide can
do like SCSI.

==
block/blk-barrier.c | 12 ++++--------
drivers/scsi/sd.c | 26 ++++++++++++++++----------
include/linux/bio.h | 2 ++
3 files changed, 22 insertions(+), 18 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH v2] fujitsu-laptop: remove unnecessary input_free_device calls
Next: [PATCH 1/2] block: introduce REQ_FLUSH flag