Prev: [PATCH 3/4] procfs: move pid_ns_prepare_proc() from copy_process() to create_pid_namespace()
Next: [PATCH 2/4] procfs: kill the global proc_mnt variable
From: Oleg Nesterov on 19 Jun 2010 15:20
On 06/18, Oleg Nesterov wrote:
>
> I only try to discuss the idea to break the circular reference.

I don't know what I have missed, but this looks really right to me.
Besides, we have yet another problem: proc_flush_task()->mntput()
is just wrong. Consider the multithreaded execing init.

I am going to simplify, test, and send the fix which moves mntput()
into free_pid_ns() paths.

But first of all I think we should cleanup the pid_ns_prepare_proc()
logic. Imho, this code is really ugly. Please see the patches.

The last one, 4/4, is orthogonal to other changes.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 3/4] procfs: move pid_ns_prepare_proc() from copy_process() to create_pid_namespace()
Next: [PATCH 2/4] procfs: kill the global proc_mnt variable