Prev: [PATCH 2/9] viafb: VIA Frame Buffer Device Driver
Next: [PATCH 5/7] au1xmmc: 4 bit transfer mode
From: Stephen Neuendorffer on 7 May 2008 12:10
> +#ifdef CONFIG_PPC_PSERIES
> +#include <asm/rtas.h>
> +#include <asm/kdump.h>
> +#include <asm/smp.h>
> +#include <asm/iommu.h>
> +#include <asm/btext.h>
> +#include <asm/machdep.h>
> +#include <asm/pSeries_reconfig.h>
> +#include <asm/phyp_dump.h>
> +#include <asm/kexec.h>
> +#endif

I don't think we need CONFIG_PPC_PSERIES (multiple times)

> +#ifdef CONFIG_PPC64
> +int __initdata iommu_is_off;
> +int __initdata iommu_force_on;
> +unsigned long tce_alloc_start, tce_alloc_end;
> +#endif

or PPC64 (multiple times

> +#ifdef CONFIG_PPC32

or PPC32

Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Grant Likely on 7 May 2008 15:10
On Wed, May 7, 2008 at 12:40 PM, Michal Simek <monstr(a)seznam.cz> wrote:
> Hi Steve,
>
> you are right. Microblaze don't need CONFIG_PPC_something but
> I keep this in files because it will be easier to move this to better place.
> I wanted to sort what Microblaze don't use.
>
> I need to talk with people from sparc and powerpc what we can move and where.
> I see the best way to push these files to microblaze/kernel/ and then sychronize
> them with one patch - all archs together.

I would disagree. I think its better to push (and get merged) patches
to move the files first; then add microblaze on top of that. You can
start getting stuff merged piecemeal that way instead of relying on
getting your entire patch series merged at once.

However, that's just my opinion, others may look at it differently.

Cheers,
g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: [PATCH 2/9] viafb: VIA Frame Buffer Device Driver
Next: [PATCH 5/7] au1xmmc: 4 bit transfer mode