Prev: XFS status update for May 2010
Next: [PATCH 06/12] Allow xen platform pci device to be compiled as a module
From: Konrad Rzeszutek Wilk on 15 Jun 2010 09:50
> +static int platform_pci_resume(struct pci_dev *pdev)
> +{
> + int err;
> + if (xen_have_vector_callback)
> + return 0;
> + err = xen_set_callback_via(callback_via);
> + if (err) {
> + printk("platform_pci_resume failure!\n");

How did you scripts/checkpatch.pl --strict let you do that?
You might want to use dev_err instead.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
From: Stefano Stabellini on 17 Jun 2010 11:50
On Mon, 14 Jun 2010, Konrad Rzeszutek Wilk wrote:
> > +static int platform_pci_resume(struct pci_dev *pdev)
> > +{
> > + int err;
> > + if (xen_have_vector_callback)
> > + return 0;
> > + err = xen_set_callback_via(callback_via);
> > + if (err) {
> > + printk("platform_pci_resume failure!\n");
>
> How did you scripts/checkpatch.pl --strict let you do that?
> You might want to use dev_err instead.
>

I'll do that and re-run checkpatch.pl on the whole series

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: XFS status update for May 2010
Next: [PATCH 06/12] Allow xen platform pci device to be compiled as a module