[PATCH 07/24] input/touchscreen: fix dangling pointers
in [Kernel]
|
Prev: [PATCH 15/24] misc/eeprom: fix dangling pointers
Next: [PATCH 22/24] staging/iio/light: fix dangling pointers
From: Wolfram Sang on 20 Mar 2010 10:20 Fix I2C-drivers which missed setting clientdata to NULL before freeing the structure it points to. Also fix drivers which do this _after_ the structure was freed already. Signed-off-by: Wolfram Sang <w.sang(a)pengutronix.de> Cc: Dmitry Torokhov <dmitry.torokhov(a)gmail.com> --- Found using coccinelle, then reviewed. Full patchset is available via kernel-janitors, linux-i2c, and LKML. --- drivers/input/touchscreen/mcs5000_ts.c | 2 +- drivers/input/touchscreen/tsc2007.c | 1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/input/touchscreen/mcs5000_ts.c b/drivers/input/touchscreen/mcs5000_ts.c index 4c28b89..98689a7 100644 --- a/drivers/input/touchscreen/mcs5000_ts.c +++ b/drivers/input/touchscreen/mcs5000_ts.c @@ -254,8 +254,8 @@ static int __devexit mcs5000_ts_remove(struct i2c_client *client) free_irq(client->irq, data); input_unregister_device(data->input_dev); - kfree(data); i2c_set_clientdata(client, NULL); + kfree(data); return 0; } diff --git a/drivers/input/touchscreen/tsc2007.c b/drivers/input/touchscreen/tsc2007.c index be23780..4c63fda 100644 --- a/drivers/input/touchscreen/tsc2007.c +++ b/drivers/input/touchscreen/tsc2007.c @@ -353,6 +353,7 @@ static int __devexit tsc2007_remove(struct i2c_client *client) pdata->exit_platform_hw(); input_unregister_device(ts->input); + i2c_set_clientdata(client, NULL); kfree(ts); return 0; -- 1.7.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |