Prev: High pitch noise when ACPI processor module is loaded.
Next: [PATCH 29/29] move w100fb's probe function to .devinit.text
From: Uwe Kleine-König on 23 Jan 2010 15:40
A pointer to epson1355fb_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
..init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig(a)pengutronix.de>
Cc: Russell King <rmk+kernel(a)arm.linux.org.uk>
Cc: Krzysztof Helt <krzysztof.h1(a)wp.pl>
Cc: Antonino Daplas <adaplas(a)gmail.com>
Cc: Andrew Morton <akpm(a)linux-foundation.org>
Cc: Paul Mundt <lethal(a)linux-sh.org>
Cc: Roland Stigge <stigge(a)antcom.de>
Cc: Greg Kroah-Hartman <gregkh(a)suse.de>
---
drivers/video/epson1355fb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/epson1355fb.c b/drivers/video/epson1355fb.c
index 2735b79..6d755bb 100644
--- a/drivers/video/epson1355fb.c
+++ b/drivers/video/epson1355fb.c
@@ -602,7 +602,7 @@ static int epson1355fb_remove(struct platform_device *dev)
return 0;
}

-int __init epson1355fb_probe(struct platform_device *dev)
+int __devinit epson1355fb_probe(struct platform_device *dev)
{
struct epson1355_par *default_par;
struct fb_info *info;
--
1.6.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
 | 
Pages: 1
Prev: High pitch noise when ACPI processor module is loaded.
Next: [PATCH 29/29] move w100fb's probe function to .devinit.text