[PATCH 08/30] hpsa: use sizeof() not an inline constant in memset.
in [Kernel]
|
Prev: [PATCH 26/30] hpsa: Fix hpsa_find_scsi_entry so that it doesn't try to dereference NULL pointers
Next: [PATCH 25/30] hpsa: clarify obscure comment in adjust_hpsa_scsi_table
From: Stephen M. Cameron on 4 Feb 2010 09:50 From: Stephen M. Cameron <scameron(a)beardog.cce.hp.com> hpsa: use sizeof() not an inline constant in memset. Signed-off-by: Stephen M. Cameron <scameron(a)beardog.cce.hp.com> --- drivers/scsi/hpsa.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 8389cce..add2ed5 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -1363,9 +1363,8 @@ static int hpsa_scsi_do_report_luns(struct ctlr_info *h, int logical, dev_err(&h->pdev->dev, "cmd_special_alloc returned NULL!\n"); return -1; } - - memset(&scsi3addr[0], 0, 8); /* address the controller */ - + /* address the controller */ + memset(scsi3addr, 0, sizeof(scsi3addr)); fill_cmd(c, logical ? HPSA_REPORT_LOG : HPSA_REPORT_PHYS, h, buf, bufsize, 0, scsi3addr, TYPE_CMD); if (extended_response) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |