[PATCH 1/1] infiniband: ulp/iser, fix error retval in iser_create_ib_conn_res
in [Kernel]
|
Prev: [PATCH 1/1] DVB-USB: gp8psk, fix potential null derefernce
Next: [Regression] 2.6.34-rc1 sky2 mtu on second port defaults to 576
From: Jiri Slaby on 16 Mar 2010 11:00 Stanse foudn unreachable code in iser_create_ib_conn_res. Namely there is switched goto and ret assignment. Switch them to make sense and return ENOMEM in case of error. Signed-off-by: Jiri Slaby <jslaby(a)suse.cz> Cc: Or Gerlitz <ogerlitz(a)voltaire.com> Cc: Roland Dreier <rolandd(a)cisco.com> --- drivers/infiniband/ulp/iser/iser_verbs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iser_verbs.c b/drivers/infiniband/ulp/iser/iser_verbs.c index 308d17b..6d4ba35 100644 --- a/drivers/infiniband/ulp/iser/iser_verbs.c +++ b/drivers/infiniband/ulp/iser/iser_verbs.c @@ -149,8 +149,8 @@ static int iser_create_ib_conn_res(struct iser_conn *ib_conn) ib_conn->login_buf = kmalloc(ISER_RX_LOGIN_SIZE, GFP_KERNEL); if (!ib_conn->login_buf) { - goto alloc_err; ret = -ENOMEM; + goto alloc_err; } ib_conn->login_dma = ib_dma_map_single(ib_conn->device->ib_device, -- 1.7.0.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo(a)vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ |